Skip to content

Remove ReentrantExportProcessor as it is not required by spec#1496

Merged
cijothomas merged 6 commits intoopen-telemetry:masterfrom
cijothomas:cijothomas/publicapi1
Nov 10, 2020
Merged

Remove ReentrantExportProcessor as it is not required by spec#1496
cijothomas merged 6 commits intoopen-telemetry:masterfrom
cijothomas:cijothomas/publicapi1

Conversation

@cijothomas
Copy link
Copy Markdown
Member

@cijothomas cijothomas commented Nov 9, 2020

As ReentrantExportProcessor is lock free, there is no guarantee Exporter.Export will not be called more than once at the same time. This is not supported by the spec

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@cijothomas cijothomas requested a review from a team November 9, 2020 23:16
@cijothomas cijothomas closed this Nov 9, 2020
@cijothomas cijothomas reopened this Nov 9, 2020
Copy link
Copy Markdown
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 10, 2020

Codecov Report

Merging #1496 (2495402) into master (32a500c) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1496   +/-   ##
=======================================
  Coverage   81.20%   81.21%           
=======================================
  Files         233      232    -1     
  Lines        6311     6303    -8     
=======================================
- Hits         5125     5119    -6     
+ Misses       1186     1184    -2     
Impacted Files Coverage Δ
...ZPages/Implementation/ZPagesExporterEventSource.cs 56.25% <0.00%> (-6.25%) ⬇️

@cijothomas cijothomas merged commit 8775969 into open-telemetry:master Nov 10, 2020
@cijothomas cijothomas deleted the cijothomas/publicapi1 branch November 10, 2020 00:31
@reyang reyang mentioned this pull request Feb 26, 2021
@reyang reyang changed the title Remove RentrantExportProcessor as it is not required by spec Remove ReentrantExportProcessor as it is not required by spec Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants