RecordException in SqlClient instrumentation#1592
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1592 +/- ##
==========================================
+ Coverage 81.76% 81.79% +0.02%
==========================================
Files 245 245
Lines 6587 6590 +3
==========================================
+ Hits 5386 5390 +4
+ Misses 1201 1200 -1
|
Support different fully-qualified exception types for AdoNet and MDS sources.
Contributor
Author
|
This is now ready for review. Highlights of changes:
|
cijothomas
reviewed
Dec 1, 2020
…entelemetry-dotnet into sqlclient-exceptions
Also updated readme and changelog
cijothomas
approved these changes
Dec 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1570.
Changes
Record exceptions as ActivityEvents in SqlClient instrumentation.
SqlClientInstrumentationOptionsnew public propertyRecordException(netcore only).CHANGELOG.mdupdated for non-trivial changes