Add unit tests for SelfDiagnosticsModule#1706
Merged
cijothomas merged 6 commits intoopen-telemetry:mainfrom Jan 29, 2021
Merged
Add unit tests for SelfDiagnosticsModule#1706cijothomas merged 6 commits intoopen-telemetry:mainfrom
cijothomas merged 6 commits intoopen-telemetry:mainfrom
Conversation
…efresher # Conflicts: # src/OpenTelemetry/Internal/SelfDiagnosticsConfigRefresher.cs
Codecov Report
@@ Coverage Diff @@
## main #1706 +/- ##
==========================================
+ Coverage 82.89% 83.16% +0.26%
==========================================
Files 193 193
Lines 6005 6005
==========================================
+ Hits 4978 4994 +16
+ Misses 1027 1011 -16
|
…resher # Conflicts: # test/OpenTelemetry.Tests/Internal/SelfDiagnosticsConfigRefresherTest.cs
cijothomas
approved these changes
Jan 29, 2021
xiang17
deleted the
xiang17/UnitTestsForSelfDiagnosticsConfigRefresher
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add unit tests that validate the fixes for #1689 works. The tests should pass once PRs #1690 and #1693 are merged.
Changes
Add unit tests for SelfDiagnosticsModule