Updated AddLegacyActivity method name to AddLegacySource#1860
Merged
cijothomas merged 8 commits intoopen-telemetry:mainfrom Mar 9, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1860 +/- ##
==========================================
- Coverage 83.77% 83.34% -0.44%
==========================================
Files 187 188 +1
Lines 5967 6130 +163
==========================================
+ Hits 4999 5109 +110
- Misses 968 1021 +53
|
eddynaka
approved these changes
Mar 1, 2021
CodeBlanch
reviewed
Mar 1, 2021
| @@ -132,9 +132,9 @@ internal TracerProviderBuilder AddProcessor(BaseProcessor<Activity> processor) | |||
| /// <summary> | |||
Member
There was a problem hiding this comment.
I think the code comments should use a plural tense. Here's an alternative:
/// <summary>
/// Adds a listener for <see cref="Activity"/> objects created with the given operation name to the <see cref="TracerProviderBuilder"/>.
/// </summary>
/// <remarks>
/// This is provided to capture legacy <see cref="Activity"/> objects creared without using the <see cref="ActivitySource"/> API.
/// </remarks>
/// <param name="tracerProviderBuilder"><see cref="TracerProviderBuilder"/> instance.</param>
/// <param name="operationName">Operation name of the <see cref="Activity"/> objects to capture.</param>
/// <returns>Returns <see cref="TracerProviderBuilder"/> for chaining.</returns>
public static TracerProviderBuilder AddLegacyActivity(this TracerProviderBuilder tracerProviderBuilder, string operationName)
Contributor
Author
There was a problem hiding this comment.
I have updated the code comments.
cijothomas
reviewed
Mar 3, 2021
| ## Unreleased | ||
|
|
||
| * Added `ForceFlush` to `TracerProvider`. ([#1837](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1837)) | ||
| * Updated the method name of `AddLegacyActivity` to `AddLegacySource` |
Member
There was a problem hiding this comment.
no need of this. as this was never released.
cijothomas
reviewed
Mar 3, 2021
…acyActivity-To-AddLegacySource
…ttps://github.com/utpilla/opentelemetry-dotnet into utpilla/Update-AddLegacyActivity-To-AddLegacySource
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
AddLegacyActivitytoAddLegacySourceCHANGELOG.mdupdated for non-trivial changes