Logs: Scopes, State, & FormattedMessage follow-up#1883
Merged
CodeBlanch merged 5 commits intoopen-telemetry:mainfrom Mar 13, 2021
Merged
Logs: Scopes, State, & FormattedMessage follow-up#1883CodeBlanch merged 5 commits intoopen-telemetry:mainfrom
CodeBlanch merged 5 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1883 +/- ##
==========================================
+ Coverage 83.34% 84.19% +0.85%
==========================================
Files 188 188
Lines 6141 6092 -49
==========================================
+ Hits 5118 5129 +11
+ Misses 1023 963 -60
|
Member
cijothomas
approved these changes
Mar 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Code review, unit tests, and performance tweaks from #1869.
I did some benchmarking and it turns out the dynamic method was actually slower & using more memory than the boxing we had before, so I removed it.
With parsing:
With boxing:
Looking at the struct used for the log extensions (LogInformation, LogWarning, etc.), the results make sense. The box only has to move the three pointers. The KVP data is already in the
object[]on the heap. The parser had to allocate a new list, and then loop over the KVPs to add them one-by-one. The mean time gets worse for each item added to the state. Oh well, they all can't be zingers.TODOs:
CHANGELOG.mdupdated for non-trivial changes