Merged
Conversation
cijothomas
reviewed
Mar 16, 2021
Codecov Report
@@ Coverage Diff @@
## main #1913 +/- ##
=======================================
Coverage ? 84.40%
=======================================
Files ? 188
Lines ? 6103
Branches ? 0
=======================================
Hits ? 5151
Misses ? 952
Partials ? 0
|
reyang
commented
Mar 16, 2021
| virtual OpenTelemetry.BaseProcessor<T>.OnForceFlush(int timeoutMilliseconds) -> bool | ||
| virtual OpenTelemetry.BaseProcessor<T>.OnShutdown(int timeoutMilliseconds) -> bool | ||
| virtual OpenTelemetry.BaseProcessor<T>.OnStart(T data) -> void | ||
| virtual OpenTelemetry.Logs.OpenTelemetryLoggerProvider.Dispose(bool disposing) -> void |
Member
Author
There was a problem hiding this comment.
This is a bit messy - changing Dispose from virtual to override is causing the complaint from the tooling.
Member
There was a problem hiding this comment.
As long as this is not considered an actual breaking change, we should be fine.
cijothomas
approved these changes
Mar 16, 2021
reyang
added
pkg:OpenTelemetry
Member
|
@open-telemetry/dotnet-approvers Could use an additional review before merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #.
Changes
Resourcesupport to OpenTelemetryLoggerProvider.Resourcesupport to the console exporter.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes