You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Once we get an ack from .NET runtime team that, Msft.Extensions.* packages will always remain backward compatible, we can remove the upper bound restriction on Msft.Extensions package. As of today, we have <6 allowed, blocking .NET 6 preview users.
This also ups the minimum version to be 3.1 (instead of 2.1), as this update will be released along 1.2.0 (Nov 2021), and 2.1* packages are out of support then.
The minimum version is kept as 2.1, to support Asp.Net Core 2.1 applications which target the .NET Framework.
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
We are still working with .NET runtime team to clarify the support policy - Microsoft.Extension.Logging version 2.1.x might be used in some old version of ASP.NET (not ASP.NET Core) which has their own lifecycle.
Either we hold this PR for now until we have good clarification, or we merge it for now and prepare for a potential revert/rollback.
some old version of ASP.NET (not ASP.NET Core) which has their own lifecycle.
I think this is Asp.Net Core (on .NET Framework), and not the "pure" Asp.Net. For such projects, the targetframework in the csproj would be net46 or net47 etc, but the nuget packages are M.E.** 2.1.*...
We are still working with .NET runtime team to clarify the support policy - Microsoft.Extension.Logging version 2.1.x might be used in some old version of ASP.NET (not ASP.NET Core) which has their own lifecycle.
Either we hold this PR for now until we have good clarification, or we merge it for now and prepare for a potential revert/rollback.
Updated the changes and description accounting for this scenario. Please re-review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logsLogging signal relatedpkg:OpenTelemetryIssues related to OpenTelemetry NuGet package
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once we get an ack from .NET runtime team that, Msft.Extensions.* packages will always remain backward compatible, we can remove the upper bound restriction on Msft.Extensions package. As of today, we have <6 allowed, blocking .NET 6 preview users.
This also ups the minimum version to be 3.1 (instead of 2.1), as this update will be released along 1.2.0 (Nov 2021), and 2.1* packages are out of support then.The minimum version is kept as 2.1, to support Asp.Net Core 2.1 applications which target the .NET Framework.
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes