Throw on invalid histogram bounds#2573
Merged
cijothomas merged 3 commits intoopen-telemetry:mainfrom Nov 9, 2021
mic-max:hist-bounds-throw
Merged
Throw on invalid histogram bounds#2573cijothomas merged 3 commits intoopen-telemetry:mainfrom mic-max:hist-bounds-throw
cijothomas merged 3 commits intoopen-telemetry:mainfrom
mic-max:hist-bounds-throw
Conversation
cijothomas
reviewed
Nov 8, 2021
Codecov Report
@@ Coverage Diff @@
## main #2573 +/- ##
==========================================
+ Coverage 80.84% 80.87% +0.02%
==========================================
Files 254 254
Lines 8552 8559 +7
==========================================
+ Hits 6914 6922 +8
+ Misses 1638 1637 -1
|
reyang
approved these changes
Nov 8, 2021
cijothomas
approved these changes
Nov 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2566
Changes
Throws
ArgumentExceptionwhen invalid histogram bounds are provided.The bounds must be in ascending order and contain distinct values.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes