Skip to content

MetricType modification to allow future additions to histogram#2693

Merged
cijothomas merged 11 commits intoopen-telemetry:mainfrom
cijothomas:cijothomas/metrictypeenum1
Nov 29, 2021
Merged

MetricType modification to allow future additions to histogram#2693
cijothomas merged 11 commits intoopen-telemetry:mainfrom
cijothomas:cijothomas/metrictypeenum1

Conversation

@cijothomas
Copy link
Copy Markdown
Member

MetricType modification to allow future additions to Histogram.

@cijothomas cijothomas requested a review from a team November 26, 2021 21:03
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 26, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@284885b). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2693   +/-   ##
=======================================
  Coverage        ?   82.97%           
=======================================
  Files           ?      249           
  Lines           ?     8703           
  Branches        ?        0           
=======================================
  Hits            ?     7221           
  Misses          ?     1482           
  Partials        ?        0           
Impacted Files Coverage Δ
...ometheus/Implementation/PrometheusSerializerExt.cs 100.00% <100.00%> (ø)
src/OpenTelemetry/Metrics/MetricTypeExtensions.cs 40.00% <100.00%> (ø)

Comment thread src/OpenTelemetry/Metrics/MetricType.cs Outdated
Comment thread src/OpenTelemetry.Exporter.Prometheus/Implementation/PrometheusSerializerExt.cs Outdated
Comment thread src/OpenTelemetry.Exporter.Prometheus/Implementation/PrometheusSerializerExt.cs Outdated
Comment thread src/OpenTelemetry/Metrics/MetricTypeExtensions.cs
@cijothomas cijothomas merged commit f153cb1 into open-telemetry:main Nov 29, 2021
@cijothomas cijothomas deleted the cijothomas/metrictypeenum1 branch November 29, 2021 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants