Do not apply ExplicitBucketHistogramConfiguration to non-histograms#3126
Merged
cijothomas merged 10 commits intoopen-telemetry:mainfrom Mar 31, 2022
Merged
Conversation
…s to non-histograms
cijothomas
approved these changes
Mar 31, 2022
reyang
approved these changes
Mar 31, 2022
Member
Author
|
Oops sorry. Just pushed the fix, so requesting another review. |
reyang
approved these changes
Mar 31, 2022
Codecov Report
@@ Coverage Diff @@
## main #3126 +/- ##
==========================================
- Coverage 84.71% 84.70% -0.02%
==========================================
Files 259 259
Lines 9220 9232 +12
==========================================
+ Hits 7811 7820 +9
- Misses 1409 1412 +3
|
CodeBlanch
reviewed
Mar 31, 2022
cijothomas
reviewed
Mar 31, 2022
… github.com:alanwest/opentelemetry-dotnet into alanwest/its-a-bird-its-a-plane-its-not-a-histogram
cijothomas
reviewed
Mar 31, 2022
cijothomas
approved these changes
Mar 31, 2022
cijothomas
reviewed
Mar 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.