Skip to content

Create span when SamplingDecision.Drop #3841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alanwest wants to merge 6 commits into from
Closed

Create span when SamplingDecision.Drop #3841

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
98cc2ac
Create span when SamplingDecision.Drop
alanwest Oct 28, 2022
02ae442
Merge branch 'main' into alanwest/allocate-more-spans-please
alanwest Feb 25, 2023
8ee9dcf
Modifiy tests to match new behavior
alanwest Feb 25, 2023
383afc8
Update changelog
alanwest Feb 25, 2023
81b56f1
Merge branch 'main' into alanwest/allocate-more-spans-please
alanwest Feb 25, 2023
61b4dd4
Fix test. Parent's span id is no longer propagated.
alanwest Feb 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 2 additions & 17 deletions src/OpenTelemetry/Trace/TracerProviderSdk.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
using System.Collections.Generic;
using System.Diagnostics;
using System.Linq;
using System.Runtime.CompilerServices;
using System.Text;
using Microsoft.Extensions.DependencyInjection;
using OpenTelemetry.Internal;
Expand Down Expand Up @@ -249,7 +248,7 @@ internal TracerProviderSdk(
else if (this.sampler is AlwaysOffSampler)
{
listener.Sample = (ref ActivityCreationOptions<ActivityContext> options) =>
!Sdk.SuppressInstrumentation ? PropagateOrIgnoreData(options.Parent) : ActivitySamplingResult.None;
!Sdk.SuppressInstrumentation ? ActivitySamplingResult.PropagationData : ActivitySamplingResult.None;
Copy link
Copy Markdown
Member

@Oberon00 Oberon00 Feb 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is extremely hard to read. There is some deep nesting of if/else/Listener callback code going on here. I would suggest to extract some (named, top-level) methods to make the code more readable/reviewable.

this.getRequestedDataAction = this.RunGetRequestedDataAlwaysOffSampler;
}
else
Expand Down Expand Up @@ -461,23 +460,9 @@ private static ActivitySamplingResult ComputeActivitySamplingResult(
{
options = options with { TraceState = samplingResult.TraceStateString };
}

return activitySamplingResult;
}

return PropagateOrIgnoreData(options.Parent);
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
private static ActivitySamplingResult PropagateOrIgnoreData(in ActivityContext parentContext)
{
var isRootSpan = parentContext.TraceId == default;

// If it is the root span or the parent is remote select PropagationData so the trace ID is preserved
// even if no activity of the trace is recorded (sampled per OpenTelemetry parlance).
return (isRootSpan || parentContext.IsRemote)
? ActivitySamplingResult.PropagationData
: ActivitySamplingResult.None;
return activitySamplingResult;
}

private void RunGetRequestedDataAlwaysOnSampler(Activity activity)
Expand Down