[ASP.NET Core] replace http.target with http.route#3903
Merged
cijothomas merged 12 commits intoopen-telemetry:mainfrom Nov 18, 2022
Merged
[ASP.NET Core] replace http.target with http.route#3903cijothomas merged 12 commits intoopen-telemetry:mainfrom
cijothomas merged 12 commits intoopen-telemetry:mainfrom
Conversation
Kielek
approved these changes
Nov 15, 2022
Kielek
approved these changes
Nov 15, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3903 +/- ##
==========================================
- Coverage 87.40% 87.36% -0.04%
==========================================
Files 278 278
Lines 10757 10757
==========================================
- Hits 9402 9398 -4
- Misses 1355 1359 +4
|
cijothomas
reviewed
Nov 15, 2022
cijothomas
approved these changes
Nov 15, 2022
Member
cijothomas
left a comment
cijothomas
left a comment
There was a problem hiding this comment.
Change looks good. Thank you.
Left a comment about better changelog for end users to quickly see what is changing.
vishweshbankwar
approved these changes
Nov 15, 2022
cijothomas
approved these changes
Nov 16, 2022
Member
|
@rinat16 Could you fix the markdownlint failure in CI? |
pellared
approved these changes
Nov 17, 2022
Co-authored-by: Robert Pająk <pellared@hotmail.com>
Member
|
@rinat16 Unfortunately other PRs got merged, and this one needs to resolve the conflicts! |
cijothomas
reviewed
Nov 18, 2022
| `net.host.name` and `net.host.port` attributes will be populated instead. | ||
| ([#3858](https://github.com/open-telemetry/opentelemetry-dotnet/pull/3858)) | ||
|
|
||
| * The `http.server.duration` metric's `http.target` attribute is replaced |
cijothomas
approved these changes
Nov 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3897
Changes
http.targetwas replaced withhttp.routeFor significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes