Skip to content

Update default value for simple exemplar reservoir size #4803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
utpilla merged 2 commits into from
Aug 28, 2023
Merged

Update default value for simple exemplar reservoir size #4803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc16b65
Update default value for simple exemplar reservoir
utpilla Aug 25, 2023
7852f81
Update CHANGELOG
utpilla Aug 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/OpenTelemetry/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
* Increased the character limit of the Meter instrument name from 63 to 255.
([#4774](https://github.com/open-telemetry/opentelemetry-dotnet/issues/4774))

* Update default size for `SimpleExemplarReservoir` to `1`.
Copy link
Copy Markdown
Member

@vishweshbankwar vishweshbankwar Aug 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/src/OpenTelemetry/CHANGELOG.md#:~:text=Experimental%20(pre%2Drelease%20builds%20only)%3A

Copy link
Copy Markdown
Contributor Author

@utpilla utpilla Aug 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to not add this. It should be okay to add this only when introducing a public API change.

([#4803](https://github.com/open-telemetry/opentelemetry-dotnet/issues/4803))

## 1.6.0-rc.1

Released 2023-Aug-21
Expand Down
3 changes: 1 addition & 2 deletions src/OpenTelemetry/Metrics/MetricPoint.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@ namespace OpenTelemetry.Metrics;
/// </summary>
public struct MetricPoint
{
// TODO: Ask spec to define a default value for this.
private const int DefaultSimpleReservoirPoolSize = 10;
private const int DefaultSimpleReservoirPoolSize = 1;

private readonly AggregatorStore aggregatorStore;

Expand Down