Skip to content

Conversation

@pengweiqhca
Copy link
Contributor

@pengweiqhca pengweiqhca commented May 8, 2025

…l.Grpc`.

Fixes #6273
Replaces: #6277

Changes

Please provide a brief description of the changes here.

Verify

  1. Start the opentelemetry-collector with the OTLP receiver enabled and TLS configured..
  2. Debug the Examples.Console.csproj project with -f net48 and the following arguments: otlp -e "https://localhost:4317" -p "grpc"
  3. Set a breakpoint in OtlpExporterTransmissionHandler.TrySubmitRequest, and response.Success should return true.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@pengweiqhca pengweiqhca requested a review from a team as a code owner May 8, 2025 23:37
@github-actions github-actions bot added the pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package label May 8, 2025
@rajkumar-rangaraj rajkumar-rangaraj changed the title [Bug] Fixed an issue in .NET Framework while using `OtlpExportProtoco… [otlp] Correct initial write position for gRPC in .NET Framework OTLP exporters May 9, 2025
@codecov
Copy link

codecov bot commented May 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.61%. Comparing base (8c1e638) to head (a2ff1bb).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6280   +/-   ##
=======================================
  Coverage   86.61%   86.61%           
=======================================
  Files         258      258           
  Lines       11795    11792    -3     
=======================================
- Hits        10216    10214    -2     
+ Misses       1579     1578    -1     
Flag Coverage Δ
unittests-Project-Experimental 86.44% <ø> (-0.02%) ⬇️
unittests-Project-Stable 86.47% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
....Exporter.OpenTelemetryProtocol/OtlpLogExporter.cs 89.65% <ø> (-0.35%) ⬇️
...porter.OpenTelemetryProtocol/OtlpMetricExporter.cs 80.76% <ø> (-0.72%) ⬇️
...xporter.OpenTelemetryProtocol/OtlpTraceExporter.cs 89.28% <ø> (-0.37%) ⬇️

... and 1 file with indirect coverage changes

@rajkumar-rangaraj rajkumar-rangaraj merged commit ee720ba into open-telemetry:main May 16, 2025
35 checks passed
@rajkumar-rangaraj
Copy link
Member

Thanks @pengweiqhca for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] OtlpXXXExporter does not work with Grpc on net framework

2 participants