Skip to content

Fix /prod -> /proc for processInfo #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025

Conversation

FengyunPan2
Copy link
Contributor

fix the processName of processInfo always null.

@FengyunPan2 FengyunPan2 requested review from a team as code owners April 16, 2025 11:25
@florianl florianl enabled auto-merge (squash) April 16, 2025 11:37
@florianl florianl merged commit 7ddc23e into open-telemetry:main Apr 16, 2025
12 checks passed
@FengyunPan2
Copy link
Contributor Author

@florianl For Java processes, the value from /proc//comm is simply "java", which is too generic to distinguish between different Java applications. Can we enhance this by incorporating the information from /proc//cmdline?

@florianl
Copy link
Contributor

@FengyunPan2 there are multiple options to distinguish different Java processes:

  • Whitelist environment variables: This will extract and enrich profiling information with environment variables information. As often makes use of environment variables, this could help.
  • Use container ID or host information: Often environment are separated in some way. Being environment aware could help.
  • ProcessMeta.Executable: While /proc/<PID>/comm sounds less useful, the value from /proc/<PID>/exe will be available via ProcessMeta.Executable and could help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants