otelgrpc: only start span if not filtered out#6695
Merged
Conversation
Member
|
Have you looked into adding a test? |
Contributor
Author
|
@dmathieu I will look into soon, Just need to test is a bit more in a specific env and will come with tests. |
Contributor
Author
|
Kind of trick to add tests, but I could do it. (I hope) |
MrAlias
reviewed
Jan 29, 2025
Contributor
Author
|
Not sure If there is something missing regarding the review, let me know. |
Member
|
Could you look into the test suite failures? |
nil filter cases
avoid extra variable
dfc0e88 to
d22cc98
Compare
Contributor
Author
Sure, my mistake, fixed, I hope now it's ok |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6695 +/- ##
=====================================
Coverage 73.1% 73.1%
=====================================
Files 191 191
Lines 15858 15866 +8
=====================================
+ Hits 11598 11606 +8
Misses 3925 3925
Partials 335 335
|
dmathieu
approved these changes
Jan 30, 2025
Co-authored-by: Damien Mathieu <42@dmathieu.com>
MrAlias
reviewed
Jan 30, 2025
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
…s_handler_test.go Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
…s_handler_test.go Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
…s_handler_test.go Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
…s_handler_test.go Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
MrAlias
approved these changes
Jan 30, 2025
Contributor
|
@dashpole does this look good to you? |
dashpole
approved these changes
Jan 30, 2025
Contributor
|
yep |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #6446
Only start a span if it's not filtered out.