Skip to content

otelgrpc: only start span if not filtered out#6695

Merged
MrAlias merged 15 commits into
open-telemetry:mainfrom
vianamjr:mviana/grpc-leak
Jan 30, 2025
Merged

otelgrpc: only start span if not filtered out#6695
MrAlias merged 15 commits into
open-telemetry:mainfrom
vianamjr:mviana/grpc-leak

Conversation

@vianamjr
Copy link
Copy Markdown
Contributor

Related to #6446

Only start a span if it's not filtered out.

@vianamjr vianamjr requested review from a team and dashpole as code owners January 29, 2025 15:15
@dmathieu
Copy link
Copy Markdown
Member

Have you looked into adding a test?

@vianamjr
Copy link
Copy Markdown
Contributor Author

@dmathieu I will look into soon, Just need to test is a bit more in a specific env and will come with tests.

@vianamjr
Copy link
Copy Markdown
Contributor Author

Kind of trick to add tests, but I could do it. (I hope)

Comment thread instrumentation/google.golang.org/grpc/otelgrpc/go.mod Outdated
@vianamjr
Copy link
Copy Markdown
Contributor Author

Not sure If there is something missing regarding the review, let me know.

@dmathieu
Copy link
Copy Markdown
Member

Could you look into the test suite failures?

@vianamjr
Copy link
Copy Markdown
Contributor Author

Could you look into the test suite failures?

Sure, my mistake, fixed, I hope now it's ok

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.1%. Comparing base (6eaddb9) to head (7f41c5d).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #6695   +/-   ##
=====================================
  Coverage   73.1%   73.1%           
=====================================
  Files        191     191           
  Lines      15858   15866    +8     
=====================================
+ Hits       11598   11606    +8     
  Misses      3925    3925           
  Partials     335     335           
Files with missing lines Coverage Δ
...n/google.golang.org/grpc/otelgrpc/stats_handler.go 100.0% <100.0%> (ø)

Comment thread CHANGELOG.md Outdated
Co-authored-by: Damien Mathieu <42@dmathieu.com>
Comment thread CHANGELOG.md Outdated
Comment thread instrumentation/google.golang.org/grpc/otelgrpc/test/grpc_stats_handler_test.go Outdated
Comment thread instrumentation/google.golang.org/grpc/otelgrpc/test/grpc_stats_handler_test.go Outdated
vianamjr and others added 6 commits January 30, 2025 11:23
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
…s_handler_test.go

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
…s_handler_test.go

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
…s_handler_test.go

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
…s_handler_test.go

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
@MrAlias
Copy link
Copy Markdown
Contributor

MrAlias commented Jan 30, 2025

@dashpole does this look good to you?

@dashpole
Copy link
Copy Markdown
Contributor

yep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants