Skip to content

otelslog, otelzap: align with code attributes semantic conventions#6870

Merged
pellared merged 6 commits into
open-telemetry:mainfrom
pellared:code-attrs
Mar 4, 2025
Merged

otelslog, otelzap: align with code attributes semantic conventions#6870
pellared merged 6 commits into
open-telemetry:mainfrom
pellared:code-attrs

Conversation

@pellared
Copy link
Copy Markdown
Member

@pellared pellared commented Mar 3, 2025

Why

Fixes #6869

Related to:

What

  • The code.function attribute emitted by the log bridges stores package path-qualified function name.
  • The code.namespace attribute is no longer added.

@github-actions github-actions Bot requested review from MrAlias and khushijain21 March 3, 2025 11:59
@pellared pellared added bridge: slog Related to the slog bridge bridge: zap Related to the zap bridge labels Mar 3, 2025
@pellared pellared changed the title Code-attrs otelslog, otelzap: Align with code semantic conventions Mar 3, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.0%. Comparing base (053acd0) to head (8a9655a).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #6870     +/-   ##
=======================================
- Coverage   76.1%   76.0%   -0.1%     
=======================================
  Files        219     219             
  Lines      21315   21299     -16     
=======================================
- Hits       16226   16207     -19     
- Misses      4529    4531      +2     
- Partials     560     561      +1     
Files with missing lines Coverage Δ
bridges/otelslog/handler.go 93.1% <100.0%> (-0.3%) ⬇️
bridges/otelzap/core.go 97.7% <100.0%> (-0.2%) ⬇️

... and 1 file with indirect coverage changes

@pellared pellared changed the title otelslog, otelzap: Align with code semantic conventions otelslog, otelzap: Align with code attributes semantic conventions Mar 3, 2025
@pellared pellared marked this pull request as ready for review March 3, 2025 12:04
@pellared pellared requested a review from a team as a code owner March 3, 2025 12:04
@pellared pellared changed the title otelslog, otelzap: Align with code attributes semantic conventions otelslog, otelzap: align with code attributes semantic conventions Mar 3, 2025
Comment thread CHANGELOG.md Outdated
pellared and others added 2 commits March 3, 2025 17:16
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bridge: slog Related to the slog bridge bridge: zap Related to the zap bridge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

log bridges: Align with code sementic conventions update

4 participants