otelzap: Add WithAttributes option#6962
Merged
dmathieu merged 4 commits intoMar 20, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6962 +/- ##
=======================================
- Coverage 75.6% 75.6% -0.1%
=======================================
Files 207 207
Lines 19354 19362 +8
=======================================
+ Hits 14646 14651 +5
- Misses 4273 4275 +2
- Partials 435 436 +1
🚀 New features to boost your workflow:
|
MrAlias
reviewed
Mar 19, 2025
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
MrAlias
approved these changes
Mar 19, 2025
khushijain21
approved these changes
Mar 20, 2025
dmathieu
approved these changes
Mar 20, 2025
Member
|
@jade-guiton-dd, thank you |
This was referenced Mar 20, 2025
github-merge-queue Bot
pushed a commit
to open-telemetry/opentelemetry-collector
that referenced
this pull request
May 30, 2025
…rWithAttributes (#13108) #### Description Now that `otelzap` has been bumped up to 0.11.0 (#13103), this PR follows up on a TODO comment to use open-telemetry/opentelemetry-go-contrib#6962 to set instrumentation scope attributes on the Logger created by otelzap, instead of a workaround (`LoggerProviderWithAttributes`). This is an internal change, and the new code should be functionally equivalent, so I don't think this needs a changelog. #### Testing I believe this is already covered by existing tests.
malus2077
pushed a commit
to malus2077/opentelemetry-collector
that referenced
this pull request
Jun 3, 2025
…rWithAttributes (open-telemetry#13108) #### Description Now that `otelzap` has been bumped up to 0.11.0 (open-telemetry#13103), this PR follows up on a TODO comment to use open-telemetry/opentelemetry-go-contrib#6962 to set instrumentation scope attributes on the Logger created by otelzap, instead of a workaround (`LoggerProviderWithAttributes`). This is an internal change, and the new code should be functionally equivalent, so I don't think this needs a changelog. #### Testing I believe this is already covered by existing tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6954, see issue for context and solution design.