otelslog: set SeverityText on log records#7198
Conversation
Thanks for feedback. Will do |
|
The linked issues are already closed as we do not plan to add this. It seems the only justification being given here is subjective and a guess at best. Is there other motivation not already provided? |
In none of those issues the intent to not support SeverityText on slog bridge in the future was expressed. In both of those issues though, the need for it was stated. One of the motivators is poor ux when querying for logs and filtering by severity. Now not having the easy and quick to grasp SeverityText will force everyone to do the seveirty matching using numeric representation which for someone outside of otel domain can be not so intuitive compared to a text representation of it. E.g. Local dev environment with console exporter configured. Chanves are users will have to add log record transformation pipelines to introduce it. I strongly believe different bridges should be on par feature wise and otel bridge should not influence the choice of logging library |
|
If we do this, it will need to be tested. |
I reopened the issue. See: #6707 (comment). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7198 +/- ##
=====================================
Coverage 81.0% 81.0%
=====================================
Files 204 204
Lines 18079 18080 +1
=====================================
+ Hits 14650 14651 +1
Misses 3003 3003
Partials 426 426
🚀 New features to boost your workflow:
|
|
Planning to merge on Friday. |
|
@adomaskizogian, thank you very much for you contribution 🥇 |
Sets SeverityText using
slog.Levelavailable at the source.Not having
SeverityTextis somewhat awkward when scouting through logs. I believe majority of software maintainers are used to having severity expressed as string.Plus otelzap does it already.
Resolves: