-
Notifications
You must be signed in to change notification settings - Fork 725
otelconf: unmarshal TextMapPropagator #8052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dmathieu
merged 7 commits into
open-telemetry:main
from
codeboten:codeboten/otelconf-textmappropagator
Oct 28, 2025
Merged
otelconf: unmarshal TextMapPropagator #8052
dmathieu
merged 7 commits into
open-telemetry:main
from
codeboten:codeboten/otelconf-textmappropagator
Oct 28, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8052 +/- ##
=======================================
+ Coverage 79.9% 80.1% +0.1%
=======================================
Files 190 190
Lines 12136 12260 +124
=======================================
+ Hits 9703 9825 +122
- Misses 2072 2073 +1
- Partials 361 362 +1
🚀 New features to boost your workflow:
|
Adds unmarshaling code for TextMapPropagator which includes supporting nillable values for the different propagators. Part of splitting open-telemetry#8026 Signed-off-by: alex boten <[email protected]>
Signed-off-by: alex boten <[email protected]>
cb3e452 to
bab02ba
Compare
Signed-off-by: alex boten <[email protected]>
Signed-off-by: alex boten <[email protected]>
MrAlias
reviewed
Oct 27, 2025
Contributor
MrAlias
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good outside of possible clean up item from a merge.
Co-authored-by: Tyler Yahn <[email protected]>
MrAlias
approved these changes
Oct 27, 2025
dmathieu
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds unmarshaling code for TextMapPropagator which includes supporting nillable values for the different propagators.
Part of splitting #8026
Will rebase after #8050