Skip to content

Conversation

@codeboten
Copy link
Contributor

Adds unmarshaling code for TextMapPropagator which includes supporting nillable values for the different propagators.

Part of splitting #8026

Will rebase after #8050

@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

❌ Patch coverage is 98.38710% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.1%. Comparing base (35a6f7b) to head (1cf9fe8).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
otelconf/config_json.go 98.0% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #8052     +/-   ##
=======================================
+ Coverage   79.9%   80.1%   +0.1%     
=======================================
  Files        190     190             
  Lines      12136   12260    +124     
=======================================
+ Hits        9703    9825    +122     
- Misses      2072    2073      +1     
- Partials     361     362      +1     
Files with missing lines Coverage Δ
otelconf/config_yaml.go 98.0% <100.0%> (+0.4%) ⬆️
otelconf/config_json.go 96.5% <98.0%> (+1.3%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Adds unmarshaling code for TextMapPropagator which includes supporting nillable values for the different propagators.

Part of splitting open-telemetry#8026

Signed-off-by: alex boten <[email protected]>
@codeboten codeboten force-pushed the codeboten/otelconf-textmappropagator branch from cb3e452 to bab02ba Compare October 27, 2025 20:06
Signed-off-by: alex boten <[email protected]>
@codeboten codeboten marked this pull request as ready for review October 27, 2025 20:07
@codeboten codeboten requested review from a team and pellared as code owners October 27, 2025 20:07
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good outside of possible clean up item from a merge.

@dmathieu dmathieu merged commit 22a753e into open-telemetry:main Oct 28, 2025
28 checks passed
@MrAlias MrAlias mentioned this pull request Dec 8, 2025
@MrAlias MrAlias added this to the v1.39.0 milestone Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants