Skip to content

fix(otelgin,otelecho): use MetricAttributes.Route#8677

Merged
dmathieu merged 2 commits into
open-telemetry:mainfrom
gaiaz-iusipov:use-route-param
Mar 17, 2026
Merged

fix(otelgin,otelecho): use MetricAttributes.Route#8677
dmathieu merged 2 commits into
open-telemetry:mainfrom
gaiaz-iusipov:use-route-param

Conversation

@gaiaz-iusipov
Copy link
Copy Markdown
Contributor

Minor changes in the components:

  • go.opentelemetry.io/contrib/instrumentation/github.com/gin-gonic/gin/otelgin
  • go.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/otelecho

Not sure whether it’s necessary to update the changelog.

@gaiaz-iusipov gaiaz-iusipov requested review from a team and flc1125 as code owners March 13, 2026 15:27
@github-actions github-actions Bot requested a review from akats7 March 13, 2026 15:27
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@c6f5e27). Learn more about missing BASE report.
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff           @@
##             main   #8677   +/-   ##
======================================
  Coverage        ?   82.1%           
======================================
  Files           ?     183           
  Lines           ?   13790           
  Branches        ?       0           
======================================
  Hits            ?   11332           
  Misses          ?    2054           
  Partials        ?     404           
Files with missing lines Coverage Δ
...umentation/github.com/gin-gonic/gin/otelgin/gin.go 92.8% <100.0%> (ø)
...entation/github.com/labstack/echo/otelecho/echo.go 100.0% <100.0%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmathieu dmathieu added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Mar 13, 2026
@dmathieu dmathieu merged commit 590c561 into open-telemetry:main Mar 17, 2026
29 checks passed
@gaiaz-iusipov gaiaz-iusipov deleted the use-route-param branch March 18, 2026 07:59
@pellared pellared added this to the v1.43.0 milestone Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants