Support reading early agent config from declarative config yaml #15770
+168
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
changed the title
zeitlinger
reviewed
Jan 6, 2026
|
|
||
| public static EarlyInitAgentConfig create() { | ||
| if (DeclarativeConfigurationFile.isConfigured()) { | ||
| return new EarlyInitAgentConfig(DeclarativeConfigurationFile.getProperties()); |
Member
There was a problem hiding this comment.
This would involve Jackson too early and cause class loading issues - I think polluting the wrong class loader.
@laurit explained that to me when I tried to do that last year.
Member
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
link doesn't work:
private static OpenTelemetryConfigurationModel loadConfigurationModel(String configurationFile) {
try (FileInputStream fis = new FileInputStream(configurationFile)) {
return DeclarativeConfiguration.parse(fis);
} catch (IOException e) {
ErrorBuffer.addErrorMessage(
"Error reading configuration file: " + configurationFile + ". " + e.getMessage());
return null;
}
}
Member
Author
There was a problem hiding this comment.
ah yes, I'll have to think on this some more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.