Declarative config for logback appender installer #15813
+27
−84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
test native
trask
reviewed
Jan 9, 2026
...entation/spring/autoconfigure/internal/instrumentation/logging/LogbackAppenderInstaller.java
Outdated
Show resolved
Hide resolved
trask
reviewed
Jan 9, 2026
...entation/spring/autoconfigure/internal/instrumentation/logging/LogbackAppenderInstaller.java
Outdated
Show resolved
Hide resolved
trask
reviewed
Jan 9, 2026
| } | ||
|
|
||
| private static Boolean evaluateBooleanProperty( | ||
| private static Boolean evaluateBooleanPropertyDeclarativeConfigOrLegacy( |
Member
There was a problem hiding this comment.
what is the "or legacy" part of this method?
Member
Author
There was a problem hiding this comment.
inlined it right into the method for clarity
String key = property;
if (EarlyConfig.isDeclarativeConfig(environment)) {
if (property.startsWith("otel.instrumentation.")) {
key =
String.format(
"otel.instrumentation/development.java.%s",
property.substring("otel.instrumentation.".length()))
.replace('-', '_');
} else {
throw new IllegalStateException(
"No mapping found for property name: " + property + ". Please report this bug.");
}
}
Member
Author
There was a problem hiding this comment.
can also do the translation the other way round - but it's still a flat string
Contributor
There was a problem hiding this comment.
I'd suggest to avoid using the word legacy
Member
Author
There was a problem hiding this comment.
I renamed it back but added a comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #15812