Rename a couple of methods to 'wrap' #15829
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 tasks
zeitlinger
approved these changes
Jan 12, 2026
laurit
reviewed
Jan 12, 2026
| } | ||
|
|
||
| public HttpClient instrument(HttpClient httpClient) throws Exception { | ||
| public HttpClient wrap(HttpClient httpClient) throws Exception { |
Contributor
There was a problem hiding this comment.
Wondering that perhaps we should use instrument instead of wrap since it is a boarder term. Here the input client isn't really wrapped, the instrumented client won't delegate to the original client, but rather creates a new client based on the original and adds the tracing interceptors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think
wraphas evolved as our method name for wrapping an instance and returning something of the same type (e.g. in JdbcTelemetry)Related to