-
Notifications
You must be signed in to change notification settings - Fork 1k
Implement stable database semconv span name #15854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
trask
wants to merge
9
commits into
open-telemetry:main
Choose a base branch
from
trask:db-semconv-span-name
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+362
−127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 tasks
33cda4b to
44a7af5
Compare
44a7af5 to
e84373c
Compare
2191bdc to
25d9106
Compare
trask
commented
Jan 13, 2026
Comment on lines
+49
to
+53
| String operationName = uniqueOperationName.getValue(); | ||
| return new MultiQuery( | ||
| uniqueCollectionName.getValue(), | ||
| uniqueStoredProcedureName.getValue(), | ||
| uniqueOperationName.getValue(), | ||
| operationName == null ? "BATCH" : "BATCH " + operationName, |
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved this here from SqlClientAttributesExtractor so I can reuse this value from DbClientSpanNameExtractor
Update span name assertions for stable semconv: - hibernate-3.3: Use conditional span name in assertClientSpan (without db prefix) - cassandra-3.0: Fix USE keyspace span name to expect 'cassandra' fallback (server.address not available at span start time)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/open-telemetry/semantic-conventions/blob/main/docs/db/database-spans.md#name
(doesn't cover
db.query.summarywhich will be covered in a future PR once that attribute is added)