Skip query sanitization for prepared statements under stable semconv flag #15855
+182
−69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
test native
trask
changed the title
trask
changed the title
trask
force-pushed
the
prepared-statement-no-sanitization
branch
2 times, most recently
from
5c413eb to
52c940f
Compare
28 tasks
trask
force-pushed
the
prepared-statement-no-sanitization
branch
from
d5b4e5d to
de6b197
Compare
PreparedStatement queries use placeholders and are already parameterized, so they don't need sanitization. This change adds an isPreparedStatement flag to DbRequest and SqlClientAttributesGetter to skip sanitization for prepared statements while still sanitizing regular Statement queries.
trask
force-pushed
the
prepared-statement-no-sanitization
branch
from
de6b197 to
02947ae
Compare
trask
force-pushed
the
prepared-statement-no-sanitization
branch
from
e173f44 to
09a4532
Compare
trask
force-pushed
the
prepared-statement-no-sanitization
branch
from
09a4532 to
aca641d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/open-telemetry/semantic-conventions/blob/main/docs/db/database-spans.md#sanitization-of-dbquerytext
TODO add opt-in to sanitize anyways?