Skip to content

Fix openj9 test failures - #20803

Merged
trask merged 2 commits into
open-telemetry:mainfrom
laurit:fix-openj9
Oct 21, 2026
Merged

trask merged 2 commits into
open-telemetry:mainfrom
laurit:fix-openj9

Conversation

@laurit

@laurit laurit commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Resolves #20802
Resolves #20796

@laurit laurit added the test openj9 This label can be applied to PRs to trigger them to run openj9 tests label Oct 21, 2026
@laurit
laurit requested a review from a team as a code owner October 21, 2026 12:19
@github-actions

Copy link
Copy Markdown
Contributor

The test openj9 label is present on this PR. If it was added after the PR's current build started, that build will not pick it up because test-* labels are only read when the build naturally runs (PR opened / synchronize / reopened). Push another commit or close and reopen the PR to run with this label.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-21T12:21:45.061827Z a44c662 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Pull request dashboard status

Merged · refreshed 2026-10-21 15:22 UTC

Status above doesn't look right?
  • Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

@opentelemetry-pr-dashboard
opentelemetry-pr-dashboard Bot requested a balanced review from Copilot October 21, 2026 12:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

These narrowly scoped test changes preserve the intended checks, with no blocking issues identified.

No open issues 🎉

Review effort: Balanced

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused test-only changes preserve the intended assertions, with no unresolved findings.

No open issues 🎉

Review effort: Balanced

@trask
trask merged commit d7bea93 into open-telemetry:main Oct 21, 2026
166 of 168 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test openj9 This label can be applied to PRs to trigger them to run openj9 tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Workflow failed: Build (daily --no-build-cache) (#1680) Workflow failed: Build (daily) (#1686)

3 participants