Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -305,6 +305,10 @@

### ⚠️ Breaking changes to non-stable APIs

- Remove `HttpClientInstrumentationExtension.forAgent()` and
`HttpServerInstrumentationExtension.forAgent()`; use
`AgentHttpClientInstrumentationExtension.create()` and
`AgentHttpServerInstrumentationExtension.create()` instead.
- `TracedOnSubscribe.perSubscription(...)` now returns `Observable.OnSubscribe<T>` instead of
`TracedOnSubscribe<T, REQUEST>`. Recompile consumers.
- Make the Netty 4.1 library's `NettyRequest` final; use it only as an opaque request view.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
import io.activej.promise.Promise;
import io.opentelemetry.instrumentation.testing.junit.InstrumentationExtension;
import io.opentelemetry.instrumentation.testing.junit.http.AbstractHttpServerTest;
import io.opentelemetry.instrumentation.testing.junit.http.HttpServerInstrumentationExtension;
import io.opentelemetry.instrumentation.testing.junit.http.AgentHttpServerInstrumentationExtension;
import io.opentelemetry.instrumentation.testing.junit.http.HttpServerTestOptions;
import io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint;
import java.util.Set;
Expand All @@ -37,7 +37,7 @@
class ActivejHttpServerTest extends AbstractHttpServerTest<HttpServer> {

@RegisterExtension
static final InstrumentationExtension testing = HttpServerInstrumentationExtension.forAgent();
static final InstrumentationExtension testing = AgentHttpServerInstrumentationExtension.create();

private static final Eventloop eventloop =
Eventloop.builder().withCurrentThread().withFatalErrorHandler(logging()).build();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import akka.stream.ActorMaterializer
import io.opentelemetry.instrumentation.testing.junit.InstrumentationExtension
import io.opentelemetry.instrumentation.testing.junit.http.{
AbstractHttpClientTest,
HttpClientInstrumentationExtension,
AgentHttpClientInstrumentationExtension,
HttpClientResult,
HttpClientTestOptions,
SingleConnection
Expand All @@ -41,7 +41,7 @@ class AkkaHttpClientInstrumentationTest
extends AbstractHttpClientTest[HttpRequest] {

@RegisterExtension val extension: InstrumentationExtension =
HttpClientInstrumentationExtension.forAgent()
AgentHttpClientInstrumentationExtension.create()

val system: ActorSystem = ActorSystem.create()
implicit val materializer: ActorMaterializer =
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ package io.opentelemetry.javaagent.instrumentation.akkahttp.v10_0
import io.opentelemetry.instrumentation.testing.junit.InstrumentationExtension
import io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint.SUCCESS
import io.opentelemetry.instrumentation.testing.junit.http.{
HttpServerInstrumentationExtension,
AgentHttpServerInstrumentationExtension,
HttpServerTestOptions
}
import io.opentelemetry.sdk.testing.assertj.{SpanDataAssert, TraceAssert}
Expand All @@ -25,7 +25,7 @@ import java.util.function.Consumer
class AkkaHttpServerInstrumentationTest
extends AbstractHttpServerInstrumentationTest {
@RegisterExtension val extension: InstrumentationExtension =
HttpServerInstrumentationExtension.forAgent()
AgentHttpServerInstrumentationExtension.create()

override protected def setupServer(): AnyRef = {
AkkaHttpTestWebServer.start(port)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ package io.opentelemetry.javaagent.instrumentation.akkahttp.v10_0

import io.opentelemetry.instrumentation.testing.junit.InstrumentationExtension
import io.opentelemetry.instrumentation.testing.junit.http.{
HttpServerInstrumentationExtension,
AgentHttpServerInstrumentationExtension,
HttpServerTestOptions
}
import org.junit.jupiter.api.extension.RegisterExtension
Expand All @@ -16,7 +16,7 @@ class AkkaHttpServerInstrumentationTestAsync
extends AbstractHttpServerInstrumentationTest {

@RegisterExtension val extension: InstrumentationExtension =
HttpServerInstrumentationExtension.forAgent()
AgentHttpServerInstrumentationExtension.create()

override protected def setupServer(): AnyRef = {
AkkaHttpTestAsyncWebServer.start(port)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
package io.opentelemetry.javaagent.instrumentation.akkahttp.v10_0

import io.opentelemetry.instrumentation.testing.junit.http.{
HttpServerInstrumentationExtension,
AgentHttpServerInstrumentationExtension,
HttpServerTestOptions
}
import io.opentelemetry.instrumentation.testing.util.TestLatestDeps.testLatestDeps
Expand All @@ -17,7 +17,7 @@ class AkkaHttpServerInstrumentationTestSync
extends AbstractHttpServerInstrumentationTest {

@RegisterExtension val extension: InstrumentationExtension =
HttpServerInstrumentationExtension.forAgent()
AgentHttpServerInstrumentationExtension.create()

override protected def setupServer(): AnyRef = {
AkkaHttpTestSyncWebServer.start(port)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ package io.opentelemetry.javaagent.instrumentation.akkahttp.v10_0

import io.opentelemetry.instrumentation.testing.junit.InstrumentationExtension
import io.opentelemetry.instrumentation.testing.junit.http.{
HttpServerInstrumentationExtension,
AgentHttpServerInstrumentationExtension,
HttpServerTestOptions
}
import org.junit.jupiter.api.extension.RegisterExtension
Expand All @@ -16,7 +16,7 @@ class AkkaHttpServerSourceInstrumentationTest
extends AbstractHttpServerInstrumentationTest {

@RegisterExtension val extension: InstrumentationExtension =
HttpServerInstrumentationExtension.forAgent()
AgentHttpServerInstrumentationExtension.create()

override protected def setupServer(): AnyRef = {
AkkaHttpTestServerSourceWebServer.start(port)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import io.opentelemetry.instrumentation.testing.internal.AutoCleanupExtension;
import io.opentelemetry.instrumentation.testing.junit.InstrumentationExtension;
import io.opentelemetry.instrumentation.testing.junit.http.AbstractHttpClientTest;
import io.opentelemetry.instrumentation.testing.junit.http.HttpClientInstrumentationExtension;
import io.opentelemetry.instrumentation.testing.junit.http.AgentHttpClientInstrumentationExtension;
import io.opentelemetry.instrumentation.testing.junit.http.HttpClientResult;
import io.opentelemetry.instrumentation.testing.junit.http.HttpClientTestOptions;
import java.io.IOException;
Expand All @@ -31,7 +31,7 @@
class ApacheHttpAsyncClientTest {

@RegisterExtension
static final InstrumentationExtension testing = HttpClientInstrumentationExtension.forAgent();
static final InstrumentationExtension testing = AgentHttpClientInstrumentationExtension.create();

@RegisterExtension static final AutoCleanupExtension cleanup = AutoCleanupExtension.create();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
import io.opentelemetry.instrumentation.testing.internal.AutoCleanupExtension;
import io.opentelemetry.instrumentation.testing.junit.InstrumentationExtension;
import io.opentelemetry.instrumentation.testing.junit.http.AbstractHttpClientTest;
import io.opentelemetry.instrumentation.testing.junit.http.HttpClientInstrumentationExtension;
import io.opentelemetry.instrumentation.testing.junit.http.AgentHttpClientInstrumentationExtension;
import io.opentelemetry.instrumentation.testing.junit.http.HttpClientResult;
import io.opentelemetry.instrumentation.testing.junit.http.HttpClientTestOptions;
import io.opentelemetry.sdk.trace.data.StatusData;
Expand Down Expand Up @@ -57,7 +57,7 @@
class ApacheHttpPipeliningClientTest extends AbstractHttpClientTest<HttpUriRequest> {

@RegisterExtension
static final InstrumentationExtension testing = HttpClientInstrumentationExtension.forAgent();
static final InstrumentationExtension testing = AgentHttpClientInstrumentationExtension.create();

private static final RequestConfig REQUEST_CONFIG =
RequestConfig.custom().setConnectTimeout((int) CONNECTION_TIMEOUT.toMillis()).build();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

import io.opentelemetry.instrumentation.testing.junit.InstrumentationExtension;
import io.opentelemetry.instrumentation.testing.junit.http.AbstractHttpClientTest;
import io.opentelemetry.instrumentation.testing.junit.http.HttpClientInstrumentationExtension;
import io.opentelemetry.instrumentation.testing.junit.http.AgentHttpClientInstrumentationExtension;
import io.opentelemetry.instrumentation.testing.junit.http.HttpClientTestOptions;
import java.net.URI;
import java.util.Map;
Expand All @@ -27,7 +27,7 @@
abstract class AbstractCommonsHttpClientTest extends AbstractHttpClientTest<HttpMethod> {

@RegisterExtension
static final InstrumentationExtension testing = HttpClientInstrumentationExtension.forAgent();
static final InstrumentationExtension testing = AgentHttpClientInstrumentationExtension.create();

private static final HttpConnectionManager connectionManager =
new MultiThreadedHttpConnectionManager();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
import static io.opentelemetry.instrumentation.testing.junit.http.AbstractHttpClientTest.READ_TIMEOUT;

import io.opentelemetry.instrumentation.testing.junit.InstrumentationExtension;
import io.opentelemetry.instrumentation.testing.junit.http.HttpClientInstrumentationExtension;
import io.opentelemetry.instrumentation.testing.junit.http.AgentHttpClientInstrumentationExtension;
import io.opentelemetry.instrumentation.testing.junit.http.HttpClientResult;
import io.opentelemetry.instrumentation.testing.junit.http.HttpClientTestOptions;
import java.io.IOException;
Expand All @@ -35,7 +35,7 @@
@TestInstance(TestInstance.Lifecycle.PER_CLASS)
class ApacheHttpClientTest {
@RegisterExtension
static final InstrumentationExtension testing = HttpClientInstrumentationExtension.forAgent();
static final InstrumentationExtension testing = AgentHttpClientInstrumentationExtension.create();

private final DefaultHttpClient client = buildClient(false);
private final DefaultHttpClient clientWithReadTimeout = buildClient(true);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import static java.util.concurrent.TimeUnit.SECONDS;

import io.opentelemetry.instrumentation.testing.junit.InstrumentationExtension;
import io.opentelemetry.instrumentation.testing.junit.http.HttpClientInstrumentationExtension;
import io.opentelemetry.instrumentation.testing.junit.http.AgentHttpClientInstrumentationExtension;
import io.opentelemetry.instrumentation.testing.junit.http.HttpClientResult;
import io.opentelemetry.instrumentation.testing.junit.http.HttpClientTestOptions;
import java.net.URI;
Expand All @@ -33,7 +33,7 @@
@TestInstance(TestInstance.Lifecycle.PER_CLASS)
class ApacheHttpAsyncClientTest {
@RegisterExtension
static final InstrumentationExtension testing = HttpClientInstrumentationExtension.forAgent();
static final InstrumentationExtension testing = AgentHttpClientInstrumentationExtension.create();

private final CloseableHttpAsyncClient client = createClient();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import static io.opentelemetry.instrumentation.testing.util.TestLatestDeps.testLatestDeps;

import io.opentelemetry.instrumentation.testing.junit.InstrumentationExtension;
import io.opentelemetry.instrumentation.testing.junit.http.HttpClientInstrumentationExtension;
import io.opentelemetry.instrumentation.testing.junit.http.AgentHttpClientInstrumentationExtension;
import io.opentelemetry.instrumentation.testing.junit.http.HttpClientResult;
import io.opentelemetry.instrumentation.testing.junit.http.HttpClientTestOptions;
import java.io.IOException;
Expand All @@ -34,7 +34,7 @@
@TestInstance(TestInstance.Lifecycle.PER_CLASS)
class ApacheHttpClientTest {
@RegisterExtension
static final InstrumentationExtension testing = HttpClientInstrumentationExtension.forAgent();
static final InstrumentationExtension testing = AgentHttpClientInstrumentationExtension.create();

private final CloseableHttpClient client = createClient();
private final CloseableHttpClient clientWithReadTimeout = createClientWithReadTimeout();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@
import com.linecorp.armeria.client.WebClientBuilder;
import io.opentelemetry.instrumentation.armeria.v1_3.AbstractArmeriaHttpClientTest;
import io.opentelemetry.instrumentation.testing.junit.InstrumentationExtension;
import io.opentelemetry.instrumentation.testing.junit.http.HttpClientInstrumentationExtension;
import io.opentelemetry.instrumentation.testing.junit.http.AgentHttpClientInstrumentationExtension;
import org.junit.jupiter.api.extension.RegisterExtension;

class ArmeriaHttpClientTest extends AbstractArmeriaHttpClientTest {

@RegisterExtension
static final InstrumentationExtension testing = HttpClientInstrumentationExtension.forAgent();
static final InstrumentationExtension testing = AgentHttpClientInstrumentationExtension.create();

@Override
protected WebClientBuilder configureClient(WebClientBuilder clientBuilder) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
import io.opentelemetry.api.trace.SpanKind;
import io.opentelemetry.instrumentation.armeria.v1_3.AbstractArmeriaHttpServerTest;
import io.opentelemetry.instrumentation.testing.junit.InstrumentationExtension;
import io.opentelemetry.instrumentation.testing.junit.http.HttpServerInstrumentationExtension;
import io.opentelemetry.instrumentation.testing.junit.http.AgentHttpServerInstrumentationExtension;
import io.opentelemetry.instrumentation.testing.junit.http.HttpServerTestOptions;
import io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint;
import io.opentelemetry.sdk.trace.data.StatusData;
Expand All @@ -40,7 +40,7 @@ class ArmeriaHttpServerTest extends AbstractArmeriaHttpServerTest {
findResponseExceptionWithCauseFactory();

@RegisterExtension
static final InstrumentationExtension testing = HttpServerInstrumentationExtension.forAgent();
static final InstrumentationExtension testing = AgentHttpServerInstrumentationExtension.create();

private final HttpResponseException wrappedResponseException =
HttpResponseException.of(HttpResponse.of(HttpStatus.OK));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
import io.opentelemetry.api.common.AttributeKey;
import io.opentelemetry.instrumentation.testing.junit.InstrumentationExtension;
import io.opentelemetry.instrumentation.testing.junit.http.AbstractHttpClientTest;
import io.opentelemetry.instrumentation.testing.junit.http.HttpClientInstrumentationExtension;
import io.opentelemetry.instrumentation.testing.junit.http.AgentHttpClientInstrumentationExtension;
import io.opentelemetry.instrumentation.testing.junit.http.HttpClientResult;
import io.opentelemetry.instrumentation.testing.junit.http.HttpClientTestOptions;
import java.io.IOException;
Expand All @@ -32,7 +32,7 @@
class AsyncHttpClientTest extends AbstractHttpClientTest<Request> {

@RegisterExtension
static final InstrumentationExtension testing = HttpClientInstrumentationExtension.forAgent();
static final InstrumentationExtension testing = AgentHttpClientInstrumentationExtension.create();

private static final int CONNECTION_TIMEOUT_MS = (int) CONNECTION_TIMEOUT.toMillis();
private static final int READ_TIMEOUT_MS = (int) READ_TIMEOUT.toMillis();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
import io.opentelemetry.api.common.AttributeKey;
import io.opentelemetry.instrumentation.testing.junit.InstrumentationExtension;
import io.opentelemetry.instrumentation.testing.junit.http.AbstractHttpClientTest;
import io.opentelemetry.instrumentation.testing.junit.http.HttpClientInstrumentationExtension;
import io.opentelemetry.instrumentation.testing.junit.http.AgentHttpClientInstrumentationExtension;
import io.opentelemetry.instrumentation.testing.junit.http.HttpClientResult;
import io.opentelemetry.instrumentation.testing.junit.http.HttpClientTestOptions;
import java.net.URI;
Expand All @@ -32,7 +32,7 @@
class AsyncHttpClientTest extends AbstractHttpClientTest<Request> {

@RegisterExtension
static final InstrumentationExtension testing = HttpClientInstrumentationExtension.forAgent();
static final InstrumentationExtension testing = AgentHttpClientInstrumentationExtension.create();

private static final int CONNECTION_TIMEOUT_MS = (int) CONNECTION_TIMEOUT.toMillis();
private static final int READ_TIMEOUT_MS = (int) READ_TIMEOUT.toMillis();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

import io.opentelemetry.instrumentation.testing.junit.InstrumentationExtension;
import io.opentelemetry.instrumentation.testing.junit.http.AbstractHttpClientTest;
import io.opentelemetry.instrumentation.testing.junit.http.HttpClientInstrumentationExtension;
import io.opentelemetry.instrumentation.testing.junit.http.AgentHttpClientInstrumentationExtension;
import io.opentelemetry.instrumentation.testing.junit.http.HttpClientResult;
import io.opentelemetry.instrumentation.testing.junit.http.HttpClientTestOptions;
import java.lang.reflect.Method;
Expand All @@ -31,7 +31,7 @@
class AsyncHttpClientTest extends AbstractHttpClientTest<Request> {

@RegisterExtension
static final InstrumentationExtension testing = HttpClientInstrumentationExtension.forAgent();
static final InstrumentationExtension testing = AgentHttpClientInstrumentationExtension.create();

private static final int CONNECTION_TIMEOUT_MS = (int) CONNECTION_TIMEOUT.toMillis();
private static final int READ_TIMEOUT_MS = (int) READ_TIMEOUT.toMillis();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
import io.opentelemetry.api.trace.SpanKind;
import io.opentelemetry.instrumentation.testing.junit.InstrumentationExtension;
import io.opentelemetry.instrumentation.testing.junit.http.AbstractHttpServerUsingTest;
import io.opentelemetry.instrumentation.testing.junit.http.HttpServerInstrumentationExtension;
import io.opentelemetry.instrumentation.testing.junit.http.AgentHttpServerInstrumentationExtension;
import org.apache.camel.CamelContext;
import org.apache.camel.ProducerTemplate;
import org.junit.jupiter.api.AfterAll;
Expand All @@ -25,7 +25,7 @@
class DirectCamelTest extends AbstractHttpServerUsingTest<ConfigurableApplicationContext> {

@RegisterExtension
static final InstrumentationExtension testing = HttpServerInstrumentationExtension.forAgent();
static final InstrumentationExtension testing = AgentHttpServerInstrumentationExtension.create();

private ConfigurableApplicationContext appContext;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
import io.opentelemetry.api.trace.SpanKind;
import io.opentelemetry.instrumentation.testing.junit.InstrumentationExtension;
import io.opentelemetry.instrumentation.testing.junit.http.AbstractHttpServerUsingTest;
import io.opentelemetry.instrumentation.testing.junit.http.HttpServerInstrumentationExtension;
import io.opentelemetry.instrumentation.testing.junit.http.AgentHttpServerInstrumentationExtension;
import org.apache.camel.CamelContext;
import org.apache.camel.ProducerTemplate;
import org.junit.jupiter.api.AfterAll;
Expand All @@ -25,7 +25,7 @@
class MulticastDirectCamelTest extends AbstractHttpServerUsingTest<ConfigurableApplicationContext> {

@RegisterExtension
static final InstrumentationExtension testing = HttpServerInstrumentationExtension.forAgent();
static final InstrumentationExtension testing = AgentHttpServerInstrumentationExtension.create();

private ConfigurableApplicationContext appContext;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
import io.opentelemetry.api.trace.SpanKind;
import io.opentelemetry.instrumentation.testing.junit.InstrumentationExtension;
import io.opentelemetry.instrumentation.testing.junit.http.AbstractHttpServerUsingTest;
import io.opentelemetry.instrumentation.testing.junit.http.HttpServerInstrumentationExtension;
import io.opentelemetry.instrumentation.testing.junit.http.AgentHttpServerInstrumentationExtension;
import io.opentelemetry.sdk.testing.assertj.SpanDataAssert;
import io.opentelemetry.semconv.SchemaUrls;
import java.util.ArrayList;
Expand All @@ -49,7 +49,7 @@
class RestCamelTest extends AbstractHttpServerUsingTest<ConfigurableApplicationContext> {

@RegisterExtension
static final InstrumentationExtension testing = HttpServerInstrumentationExtension.forAgent();
static final InstrumentationExtension testing = AgentHttpServerInstrumentationExtension.create();

private ConfigurableApplicationContext appContext;

Expand Down
Loading
Loading