Repository navigation
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Pull request dashboard statusWaiting on reviewers · refreshed 2026-10-23 23:11 UTC Review the latest changes. Status above doesn't look right?
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are confined to the standalone reproducer, with no unresolved review findings or production instrumentation changes.
No open issues 🎉
What changed in this PR
Adds an isolated Docker-based Spring MVC WAR reproducer for the RequestPath loader-constraint failure during agent bean initialization. It compares released agents and deployment layouts without changing production instrumentation.
Changes:
- Adds a Java 8 WAR application and pinned Docker environment with configurable Spring dependency placement.
- Adds a Python runner that captures diagnostics, classifies failures, and compares agent and no-agent controls.
- Documents reproduction steps, recorded results, and investigation limitations.
| File | Description |
|---|---|
| examples/spring-war-compatibility/test_run.py | Tests failure classification and Docker launcher behavior. |
| examples/spring-war-compatibility/src/main/webapp/WEB-INF/web.xml | Registers listeners and the MVC servlet. |
| examples/spring-war-compatibility/src/main/webapp/WEB-INF/servlet.xml | Defines the empty servlet application context. |
| examples/spring-war-compatibility/src/main/webapp/WEB-INF/root.xml | Configures MVC and the probe controller. |
| examples/spring-war-compatibility/src/main/webapp/WEB-INF/path-patterns.xml | Enables path-pattern matching for the second WAR. |
| examples/spring-war-compatibility/src/main/java/io/opentelemetry/examples/springwar/ProbeController.java | Exposes health and class-origin diagnostics. |
| examples/spring-war-compatibility/src/main/java/io/opentelemetry/examples/springwar/LoaderListener.java | Logs runtime and classloader identities. |
| examples/spring-war-compatibility/run.py | Runs comparisons and saves classified evidence. |
| examples/spring-war-compatibility/RESULTS.md | Records observations, controls, and limitations. |
| examples/spring-war-compatibility/README.md | Explains setup, deployment, and classification. |
| examples/spring-war-compatibility/pom.xml | Defines the standalone Java 8 WAR build. |
| examples/spring-war-compatibility/Dockerfile | Builds dependency layouts and packages released agents. |
| examples/spring-war-compatibility/.gitignore | Excludes generated results and build artifacts. |
| examples/spring-war-compatibility/.dockerignore | Limits Docker build inputs. |
Review effort: Balanced
trask
commented
Oct 23, 2026
Co-authored-by: trask <218610+trask@users.noreply.github.com>
trask
changed the title
trask
commented
Oct 23, 2026
| include(":smoke-tests:images:servlet") | ||
| include(":smoke-tests:images:servlet:servlet-3.0") | ||
| include(":smoke-tests:images:servlet:servlet-5.0") | ||
| include(":smoke-tests:images:servlet:spring-war") |
Member
Author
There was a problem hiding this comment.
@laurit I could go either way on keeping the test 🤷♂️
trask
marked this pull request as ready for review
October 23, 2026 22:51
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Spring MVC agent initialization when different Spring versions are loaded by a WAR and Tomcat's common classloader.
Fixes #13249.
Resolve
ServletRequestPathUtils.parseAndCachefrom its declaring class instead of independently resolving itsRequestPathreturn type. This avoids creating a conflicting loader constraint that can prevent a later application'sContextLoaderListenerfrom initializingotelAutoDispatcherFilter.Replace the standalone investigation with a native Tomcat smoke regression and no-agent control. The regression deploys a Spring 5.2 WAR before a second WAR using common-loader Spring 5.3, then requires both HTTP endpoints and the agent's server spans to work. It exercises the repository-built agent, including the current indy implementation.
The WAR fixture is built and deployed automatically by the regression test. Run both agent and no-agent cases on Windows with Java 25 and Docker's Linux containers: