Repository navigation
Conversation
Pull request dashboard statusWaiting on reviewers · refreshed 2026-10-24 04:02 UTC Review the latest changes. Status above doesn't look right?
|
Co-authored-by: trask <218610+trask@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add small passing regression for FluxMessageChannel.subscribeTo
Add agent-enabled FluxMessageChannel.subscribeTo regression
Oct 24, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused test-only changes preserve baseline isolation, use existing agent-enabled test wiring, and have no identified blocking issues.
No open issues 🎉
What changed in this PR
Adds an agent-enabled regression test for context propagation through FluxMessageChannel.subscribeTo(), without changing production instrumentation or the Spring Integration 4.1 baseline.
Changes:
- Verifies producer → process → handler span parentage, emitter context restoration, and delivery within a timeout.
- Adds an isolated test suite with compatible Spring Integration/Reactor dependencies and Reactor instrumentation, excluding it from container-service usage.
| File | Description |
|---|---|
| instrumentation/spring/spring-integration-4.1/javaagent/src/fluxChannelTest/java/io/opentelemetry/javaagent/instrumentation/spring/integration/v4_1/FluxMessageChannelTest.java | Adds the reactive handoff regression and telemetry assertions. |
| instrumentation/spring/spring-integration-4.1/javaagent/build.gradle.kts | Configures the isolated suite and required instrumentation. |
Review effort: Balanced
trask
reviewed
Oct 24, 2026
Co-authored-by: trask <218610+trask@users.noreply.github.com>
trask
marked this pull request as ready for review
October 24, 2026 04:02
trask
approved these changes
Oct 24, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add focused regression coverage for the reactive-channel context propagation investigated in #3096. A hot publisher subscribed outside the producer context emits through
FluxMessageChannel.subscribeTo(), and channel processing and the handler retain the producer's trace context.This test is extracted from the fuller HTTP → Spring Cloud Stream → RabbitMQ reproducer in #20920. Its sequential-message case passes with current instrumentation. That PR is being closed without merging the larger fixture, retaining only this focused coverage.