Promote Span addLink to stable API#6317
Merged
jack-berg merged 1 commit intoopen-telemetry:mainfrom Apr 4, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6317 +/- ##
============================================
- Coverage 91.04% 91.02% -0.02%
+ Complexity 5726 5725 -1
============================================
Files 625 624 -1
Lines 16744 16744
Branches 1713 1713
============================================
- Hits 15244 15242 -2
Misses 1006 1006
- Partials 494 496 +2 ☔ View full report in Codecov by Sentry. |
zeitlinger
approved these changes
Apr 4, 2024
jkwatson
approved these changes
Apr 4, 2024
Contributor
jkwatson
left a comment
jkwatson
left a comment
There was a problem hiding this comment.
public API change approved (didn't review the implementation much)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AddLink was stabilized in the spec here: open-telemetry/opentelemetry-specification#3887