-
Notifications
You must be signed in to change notification settings - Fork 584
chore: rename workspace dirs to packages/${package-base-name} (extreme edition) #2920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…e edition) This is take 2 of open-telemetry#2223 This implements option 3 of open-telemetry#2223 (comment) (i.e. the "extreme" option)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2920 +/- ##
=======================================
Coverage 89.76% 89.76%
=======================================
Files 187 187
Lines 9149 9149
Branches 1885 1885
=======================================
Hits 8213 8213
Misses 936 936
🚀 New features to boost your workflow:
|
This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature. |
Closed in favour of #2928 (a re-run of my script -- and some manual work -- based on the latest 'main'). |
This PR is the final take of the plan discussed at #2223. This implements option 3 of #2223 (comment) (i.e. the "extreme" option). Before this change the packages published from this repo were spread across these workspace dirs: "packages/*", "plugins/node/*", "plugins/web/*", "propagators/*", "detectors/node/*", "metapackages/*" with the directory name *usually* matching the npm package name, and with or without a leading "opentelemetry-". This PR normalizes all dirs to be under "packages/*" and to have the base dir match the package name (excluding the npm `@opentelemetry/` org prefix). Obsoletes: #2223 Obsoletes: #2920
This is take 2 of #2223
This implements option 3 of #2223 (comment)
(i.e. the "extreme" option)
Status
DO NOT MERGE
Let's not merge this yet, even if agreed on doing this. I think we can finish the instr-redis consolidation, and drop the redis-common package first.