Skip to content

chore: rename workspace dirs to packages/${package-base-name} (extreme edition) #2920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

trentm
Copy link
Contributor

@trentm trentm commented Jun 27, 2025

This is take 2 of #2223
This implements option 3 of #2223 (comment)
(i.e. the "extreme" option)

Status

DO NOT MERGE

Let's not merge this yet, even if agreed on doing this. I think we can finish the instr-redis consolidation, and drop the redis-common package first.

…e edition)

This is take 2 of open-telemetry#2223
This implements option 3 of open-telemetry#2223 (comment)
(i.e. the "extreme" option)
Copy link

codecov bot commented Jun 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.76%. Comparing base (c8fa46d) to head (a835c10).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2920   +/-   ##
=======================================
  Coverage   89.76%   89.76%           
=======================================
  Files         187      187           
  Lines        9149     9149           
  Branches     1885     1885           
=======================================
  Hits         8213     8213           
  Misses        936      936           
Files with missing lines Coverage Δ
...ckages/auto-configuration-propagators/src/utils.ts 84.84% <ø> (ø)
packages/auto-instrumentations-node/src/utils.ts 98.26% <ø> (ø)
packages/auto-instrumentations-web/src/utils.ts 95.83% <ø> (ø)
packages/host-metrics/src/BaseMetrics.ts 100.00% <ø> (ø)
packages/host-metrics/src/enum.ts 100.00% <ø> (ø)
packages/host-metrics/src/metric.ts 100.00% <ø> (ø)
packages/host-metrics/src/stats/common.ts 97.91% <ø> (ø)
packages/host-metrics/src/stats/si.ts 66.66% <ø> (ø)
...erator-aws-xray/src/internal/xray-id-generation.ts 100.00% <ø> (ø)
...ckages/id-generator-aws-xray/src/platform/index.ts 100.00% <ø> (ø)
... and 36 more

... and 270 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature.
Are you familiar with this package? Consider becoming a component owner.

@trentm
Copy link
Contributor Author

trentm commented Jul 7, 2025

Closed in favour of #2928 (a re-run of my script -- and some manual work -- based on the latest 'main').

@trentm trentm closed this Jul 7, 2025
@trentm trentm deleted the trentm-all-your-dir-2 branch July 7, 2025 18:19
trentm added a commit that referenced this pull request Jul 8, 2025
This PR is the final take of the plan discussed at #2223.
This implements option 3 of #2223 (comment)
(i.e. the "extreme" option).

Before this change the packages published from this repo were spread
across these workspace dirs:

    "packages/*",
    "plugins/node/*",
    "plugins/web/*",
    "propagators/*",
    "detectors/node/*",
    "metapackages/*"

with the directory name *usually* matching the npm package name, and
with or without a leading "opentelemetry-". This PR normalizes all dirs
to be under "packages/*" and to have the base dir match the package
name (excluding the npm `@opentelemetry/` org prefix).

Obsoletes: #2223
Obsoletes: #2920
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants