fix: avoid grpc types dependency#3551
Merged
dyladan merged 6 commits intoopen-telemetry:mainfrom Jan 25, 2023
Merged
Conversation
Avoid a dependency to grpc types by moving the into a internal-types.ts file.
Flarna
commented
Jan 19, 2023
pichlermarc
approved these changes
Jan 19, 2023
Member
pichlermarc
left a comment
pichlermarc
left a comment
There was a problem hiding this comment.
Thank you for fixing this! 🙂
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3551 +/- ##
==========================================
- Coverage 93.80% 92.81% -1.00%
==========================================
Files 249 133 -116
Lines 7640 3227 -4413
Branches 1589 666 -923
==========================================
- Hits 7167 2995 -4172
+ Misses 473 232 -241
|
Member
|
Failing test seemed unrelated to this PR (looks like a network connectivity problem); it should be gone after the rebase 🙂 |
Member
Author
|
@open-telemetry/javascript-maintainers Any chance to move this forward? Currently contrib updates to latest SDK is blocked because of this (see open-telemetry/opentelemetry-js-contrib#1358) |
Member
|
@Flarna i'm back from vacation now i'll get this out asap |
dyladan
approved these changes
Jan 25, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #3548
Refs: #3386
Refs: open-telemetry/opentelemetry-js-contrib#1358
Short description of the changes
Avoid a dependency to grpc types by moving the into a internal-types.ts file.
Type of change
How Has This Been Tested?
Local compile and look into resulting .d.ts files
Checklist: