feat(browser otlp exporter): add fetch transport for fetch-only environments #5807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SacDeNoeuds
changed the title
…on, xhr and fetch delegates
SacDeNoeuds
force-pushed
the
feat/otlp-exporter--base-fetch-transport
branch
from
2c4a8b6 to
e3cd53a
Compare
dyladan
reviewed
Jul 22, 2025
There was a problem hiding this comment.
Seems reasonable to me and I don't see any obvious issues. I'd wait for @pichlermarc review before merging because he's much closer to the exporters but overall LGTM
experimental/packages/otlp-exporter-base/src/transport/fetch-transport.ts
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5807 +/- ##
=======================================
Coverage 95.01% 95.01%
=======================================
Files 303 303
Lines 7946 7946
Branches 1607 1607
=======================================
Hits 7550 7550
Misses 396 396 🚀 New features to boost your workflow:
|
| : 'cors' | ||
| : 'no-cors', | ||
| }); | ||
| clearTimeout(timeout); |
There was a problem hiding this comment.
Looks like it's possible you won't clear the timeout if something in the try block throws. Consider moving this to a finally block?
There was a problem hiding this comment.
Thanks for your review, I made the change. Let me know if I can do anything more.
|
Hi guys, any news on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
In service workers,
XMLHttpRequestandnavigator.sendBeaconare both unavailable, making theOTLPTraceExporterfrom@opentelemetry/exporter-trace-otlp-httpunusable.Fixes #4631
Short description of the changes
Add the fetch transport and enables it only when both xhr and beacons are unavailable.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I took the xhr transport tests and adapted the
arrangestep for the fetch transport.See the test file: experimental/packages/otlp-exporter-base/test/browser/fetch-transport.test.ts
Checklist:
Additional context