feat(targetallocator): auto-create RBAC for standalone TargetAllocator#5148
Open
frzifus wants to merge 1 commit into
Open
feat(targetallocator): auto-create RBAC for standalone TargetAllocator#5148frzifus wants to merge 1 commit into
frzifus wants to merge 1 commit into
Conversation
When CreateRBACPermissions is enabled, generate a ClusterRole and ClusterRoleBinding for standalone TargetAllocator CRs with the permissions needed for Prometheus CR discovery. Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
frzifus
force-pushed
the
feat/targetallocator-auto-rbac
branch
from
May 26, 2026 18:40
b7a5127 to
dca1bfc
Compare
pavolloffay
reviewed
Jun 1, 2026
| - apiGroups: | ||
| - rbac.authorization.k8s.io | ||
| resources: | ||
| - clusterrolebindings |
Member
There was a problem hiding this comment.
shouldn't this be optional? e.g. user should grant these permissions explicitly
| }, | ||
| { | ||
| APIGroups: []string{"networking.k8s.io"}, | ||
| Resources: []string{"ingresses"}, |
Member
There was a problem hiding this comment.
is this really required by TA?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--create-rbac-permissionsis enabled, the operator now generates aClusterRoleandClusterRoleBindingfor standaloneTargetAllocatorCRs🤖 Generated with Claude Code