Skip to content

Conversation

@brettmc
Copy link
Contributor

@brettmc brettmc commented Aug 29, 2023

adding a configuration option OTEL_PHP_INTERNAL_METRICS_ENABLED which controls whether the SDK will emit its own metrics (eg batch processor state).

adding a configuration option OTEL_PHP_INTERNAL_METRICS_ENABLED which
controls whether the SDK will emit its own metrics (eg batch processor
state).
@brettmc brettmc requested a review from a team August 29, 2023 04:47
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #1106 (9315c8f) into main (82f0c44) will decrease coverage by 0.09%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head 9315c8f differs from pull request most recent head 3dd1079. Consider uploading reports for the commit 3dd1079 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1106      +/-   ##
============================================
- Coverage     83.13%   83.05%   -0.09%     
+ Complexity     2202     2151      -51     
============================================
  Files           282      278       -4     
  Lines          6275     6119     -156     
============================================
- Hits           5217     5082     -135     
+ Misses         1058     1037      -21     
Flag Coverage Δ
7.4 81.66% <100.00%> (-0.12%) ⬇️
8.0 82.97% <100.00%> (-0.09%) ⬇️
8.1 83.11% <100.00%> (-0.09%) ⬇️
8.2 83.11% <100.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/SDK/Common/Time/SystemClock.php 64.28% <ø> (+19.28%) ⬆️
src/SDK/Metrics/MeterProviderBuilder.php 0.00% <ø> (ø)
src/SDK/Resource/ResourceInfoFactory.php 100.00% <ø> (+11.36%) ⬆️
src/SDK/SdkAutoloader.php 93.93% <100.00%> (+0.18%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82f0c44...3dd1079. Read the comment docs.

@brettmc brettmc merged commit 197a7a4 into open-telemetry:main Aug 30, 2023
@brettmc brettmc deleted the optional-internal-metrics branch January 29, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants