add minimal auto-instrumentation hook functions #1358
Conversation
add OpenTelemetry\API\Instrumentation\Handler, which will be the default pre/post hook callbacks for attribute-based auto-instrumentation.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1358 +/- ##
============================================
- Coverage 74.16% 73.91% -0.26%
- Complexity 2584 2648 +64
============================================
Files 373 380 +7
Lines 7429 7576 +147
============================================
+ Hits 5510 5600 +90
- Misses 1919 1976 +57
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 29 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
src/API/Instrumentation/Handler.php
Outdated
| use OpenTelemetry\Context\Context; | ||
| use Throwable; | ||
|
|
||
| class Handler |
There was a problem hiding this comment.
Maybe the name of this class could reflect that this is the handler specifically for creating spans? It is the most common purpose why functions are instrumented, but would still be nice for it to be explicit.
There was a problem hiding this comment.
Maybe /WithSpan/Handler or WithSpanHandler ?
There was a problem hiding this comment.
Latter seems to make more sense to me.
There was a problem hiding this comment.
renamed to WithSpanHandler
2 participants
add OpenTelemetry\API\Instrumentation\Handler, which will be the default pre/post hook callbacks for attribute-based auto-instrumentation.
Related: open-telemetry/opentelemetry-php-instrumentation#146