Skip to content

Conversation

@brettmc
Copy link
Contributor

@brettmc brettmc commented Aug 18, 2024

php8.4 deprecates implicit null (now checked by phan)

php8.4 deprecates implicit null (now checked by phan)
@brettmc brettmc requested a review from a team August 18, 2024 12:21
@codecov
Copy link

codecov bot commented Aug 18, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.86%. Comparing base (80e97da) to head (255f267).
Report is 1 commits behind head on main.

Files Patch % Lines
src/API/Baggage/BaggageBuilder.php 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1362      +/-   ##
============================================
- Coverage     73.94%   73.86%   -0.09%     
  Complexity     2641     2641              
============================================
  Files           379      379              
  Lines          7546     7545       -1     
============================================
- Hits           5580     5573       -7     
- Misses         1966     1972       +6     
Flag Coverage Δ
8.1 73.59% <91.66%> (-0.02%) ⬇️
8.2 73.77% <91.66%> (+<0.01%) ⬆️
8.3 73.81% <91.66%> (+<0.01%) ⬆️
8.4 73.80% <91.66%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/API/Logs/LogRecord.php 100.00% <100.00%> (ø)
src/API/Trace/NonRecordingSpan.php 90.00% <100.00%> (ø)
src/Context/Propagation/MultiTextMapPropagator.php 100.00% <100.00%> (ø)
src/Contrib/Zipkin/Exporter.php 100.00% <ø> (ø)
src/SDK/Common/Dev/Compatibility/Util.php 100.00% <100.00%> (ø)
src/SDK/Logs/EventLogger.php 100.00% <ø> (ø)
src/SDK/Logs/LoggerProvider.php 100.00% <100.00%> (ø)
src/SDK/Metrics/MeterProvider.php 91.83% <ø> (-0.17%) ⬇️
src/SDK/Trace/Span.php 94.52% <100.00%> (ø)
src/SDK/Trace/TracerProvider.php 100.00% <ø> (ø)
... and 1 more

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80e97da...255f267. Read the comment docs.

@brettmc brettmc merged commit 69825d3 into open-telemetry:main Aug 21, 2024
@brettmc brettmc deleted the implicit-null branch January 29, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants