adding config provider #1366
Merged
adding config provider #1366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1366 +/- ##
============================================
+ Coverage 73.87% 74.06% +0.18%
- Complexity 2641 2664 +23
============================================
Files 379 383 +4
Lines 7545 7634 +89
============================================
+ Hits 5574 5654 +80
- Misses 1971 1980 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
implement recent additions to the otel spec re: config provider. Config provider should return a ConfigProperties, but we were already returning a ConfigurationRegistry. Added a ConfigProperties interface for ConfigurationRegistry to implement, which gets us pretty close to spec. We don't make ConfigProvider globally available, instead passing the ConfigurationRegistry in to each instrumentation as we register it. The spec allows for this.
brettmc
force-pushed
the
config-provider
branch
from
5b99525 to
b0604d7
Compare
Co-authored-by: Chris Lightfoot-Wild <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement recent additions to the otel spec re: config provider. Config provider should return a ConfigProperties, but we were already returning a ConfigurationRegistry. Added a ConfigProperties interface for ConfigurationRegistry to implement, which gets us pretty close to spec. We don't make ConfigProvider globally available, instead passing the ConfigurationRegistry in to each instrumentation as we register it. The spec allows for this.