-
Notifications
You must be signed in to change notification settings - Fork 215
2.x prep #1463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.x prep #1463
Changes from 9 commits
0eb41f2
0a4daed
059adb6
26222f3
4ad18d6
09ea81d
1e948e8
2706cd7
18ba6be
a850cf5
eae03c1
540c47a
739cbf9
d1167c9
47d8292
397d818
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,8 +4,8 @@ on: | |
| branches: | ||
| - main | ||
| - split | ||
| release: | ||
| types: [published] | ||
| - 1.x | ||
| - 2.x | ||
| create: | ||
| workflow_dispatch: | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -35,3 +35,4 @@ splits: | |
| origins: | ||
| - ^main$ | ||
| - ^split$ | ||
| - ^2.x^ | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,13 +17,12 @@ | |
| } | ||
| ], | ||
| "require": { | ||
| "php": "^8.1", | ||
| "open-telemetry/context": "^1.0", | ||
| "psr/log": "^1.1|^2.0|^3.0", | ||
| "symfony/polyfill-php82": "^1.26" | ||
| "php": "^8.2", | ||
| "open-telemetry/context": "^2.0", | ||
| "psr/log": "^1.1|^2.0|^3.0" | ||
| }, | ||
| "conflict": { | ||
| "open-telemetry/sdk": "<=1.0.8" | ||
| "open-telemetry/sdk": "<=2.x-dev" | ||
| }, | ||
| "autoload": { | ||
| "psr-4": { | ||
|
|
@@ -35,7 +34,8 @@ | |
| }, | ||
| "extra": { | ||
| "branch-alias": { | ||
| "dev-main": "1.1.x-dev" | ||
| "dev-main": "1.1.x-dev", | ||
| "dev-2.x": "2.x-dev" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should consider keeping the API and Context packages on
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That's reasonable. They will still exist in the 2.x branch (as will proto, semconv), but we can avoid releasing a new version until we do make a breaking change. I think the most likely trigger for this would be removing the registry in favour of SPI (and possibly removing globals initializers at the same time). |
||
| }, | ||
| "spi": { | ||
| "OpenTelemetry\\API\\Instrumentation\\AutoInstrumentation\\HookManagerInterface": [ | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above; based on https://github.com/open-telemetry/opentelemetry-proto version?