Skip to content

Conversation

@brettmc
Copy link
Contributor

@brettmc brettmc commented Jan 14, 2025

upstream config now splits otlp exporters into otlp_http and otlp_grpc

Reference: open-telemetry/opentelemetry-configuration#146

upstream config now splits otlp exporters into otlp_http and otlp_grpc
@brettmc brettmc requested a review from a team as a code owner January 14, 2025 01:41
@codecov
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 144 lines in your changes missing coverage. Please review.

Project coverage is 71.21%. Comparing base (83cddd9) to head (df1737b).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...mponentProvider/Metrics/MetricExporterOtlpHttp.php 0.00% 51 Missing ⚠️
...mponentProvider/Logs/LogRecordExporterOtlpHttp.php 0.00% 38 Missing ⚠️
...K/ComponentProvider/Trace/SpanExporterOtlpHttp.php 0.00% 38 Missing ⚠️
...mponentProvider/Logs/LogRecordExporterOtlpGrpc.php 0.00% 5 Missing ⚠️
...mponentProvider/Metrics/MetricExporterOtlpGrpc.php 0.00% 5 Missing ⚠️
...K/ComponentProvider/Trace/SpanExporterOtlpGrpc.php 0.00% 5 Missing ⚠️
...SDK/ComponentProvider/Trace/SpanExporterZipkin.php 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1477      +/-   ##
============================================
- Coverage     72.25%   71.21%   -1.04%     
- Complexity     2730     2745      +15     
============================================
  Files           401      404       +3     
  Lines          8148     8272     +124     
============================================
+ Hits           5887     5891       +4     
- Misses         2261     2381     +120     
Flag Coverage Δ
8.1 70.87% <0.00%> (-1.03%) ⬇️
8.2 71.13% <0.00%> (-1.02%) ⬇️
8.3 71.02% <0.00%> (-1.09%) ⬇️
8.4 71.04% <0.00%> (-1.18%) ⬇️
8.5 71.05% <0.00%> (-1.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...SDK/ComponentProvider/Trace/SpanExporterZipkin.php 0.00% <0.00%> (ø)
...mponentProvider/Logs/LogRecordExporterOtlpGrpc.php 0.00% <0.00%> (ø)
...mponentProvider/Metrics/MetricExporterOtlpGrpc.php 0.00% <0.00%> (ø)
...K/ComponentProvider/Trace/SpanExporterOtlpGrpc.php 0.00% <0.00%> (ø)
...mponentProvider/Logs/LogRecordExporterOtlpHttp.php 0.00% <0.00%> (ø)
...K/ComponentProvider/Trace/SpanExporterOtlpHttp.php 0.00% <0.00%> (ø)
...mponentProvider/Metrics/MetricExporterOtlpHttp.php 0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83cddd9...df1737b. Read the comment docs.

"open-telemetry/exporter-otlp": "1.0.x-dev",
"open-telemetry/exporter-zipkin": "1.0.x-dev",
"open-telemetry/extension-propagator-b3": "1.0.x-dev",
"open-telemetry/extension-propagator-cloudtrace": "1.0.x-dev",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated but noticed when adding transport-grpc

@agoallikmaa
Copy link

What are the ramifications of this on configurations of existing deployments? If this is released as a non-major version of exporter-otlp, it would propagate to everyone who uses ^1 constraint for that on next update, breaking their configuration for the next run. Would it perhaps make sense to merge this to 2.x?

@brettmc
Copy link
Contributor Author

brettmc commented Jan 14, 2025

What are the ramifications of this on configurations of existing deployments? If this is released as a non-major version of exporter-otlp, it would propagate to everyone who uses ^1 constraint for that on next update, breaking their configuration for the next run. Would it perhaps make sense to merge this to 2.x?

It would break for those using the configuration module. But, it's still at version 0.x, and based on a development-stability part of the spec, so breakages are expected at this point. There are no changes to exporter-otlp.

@brettmc brettmc merged commit a4119f9 into open-telemetry:main Jan 20, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants