Skip to content

Conversation

@brettmc
Copy link
Contributor

@brettmc brettmc commented Jan 28, 2025

add a test to demonstrate that mutations are still seen by later processors without by-reference

add a test to demonstrate that mutations are still seen by later processors without by-reference
@brettmc brettmc requested a review from a team as a code owner January 28, 2025 23:49
@codecov
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.24%. Comparing base (27dfc42) to head (25498e7).
Report is 6 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #1492      +/-   ##
============================================
- Coverage     72.37%   72.24%   -0.13%     
  Complexity     2733     2733              
============================================
  Files           402      402              
  Lines          8169     8169              
============================================
- Hits           5912     5902      -10     
- Misses         2257     2267      +10     
Flag Coverage Δ
8.2 72.21% <100.00%> (-0.04%) ⬇️
8.3 72.18% <100.00%> (-0.09%) ⬇️
8.4 72.19% <100.00%> (ø)
8.5 72.17% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/SDK/Logs/Processor/BatchLogRecordProcessor.php 100.00% <100.00%> (ø)
src/SDK/Logs/Processor/MultiLogRecordProcessor.php 100.00% <100.00%> (ø)
src/SDK/Logs/Processor/NoopLogRecordProcessor.php 100.00% <ø> (ø)
...rc/SDK/Logs/Processor/SimpleLogRecordProcessor.php 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27dfc42...25498e7. Read the comment docs.

@brettmc brettmc merged commit 3fa6101 into open-telemetry:2.x Jan 29, 2025
9 of 10 checks passed
@brettmc brettmc deleted the logrecord_onemit_remove_byreference branch January 29, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants