Skip to content

Conversation

@ycchuang99
Copy link
Contributor

@ycchuang99 ycchuang99 commented Apr 15, 2025

Deprecate FilterAttributes class and its related functions.

Closes: #1535

@ycchuang99 ycchuang99 requested a review from a team as a code owner April 15, 2025 14:41
@welcome
Copy link

welcome bot commented Apr 15, 2025

Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one.

@brettmc
Copy link
Contributor

brettmc commented Apr 15, 2025

Hi @ycchuang99 sorry I hadn't seen the related issue. Since those classes are all marked @internal, they should not be being directly used by anybody and we don't make any stability guarantees. So, they can be removed entirely.

@ycchuang99
Copy link
Contributor Author

Hi @brettmc Thanks for the clarification! I'll go ahead and remove them. Appreciate the quick response!

@ycchuang99 ycchuang99 marked this pull request as draft April 16, 2025 08:09
@ycchuang99 ycchuang99 force-pushed the deprecate-drop-general-identity-attributes branch from d5787f7 to 83ec475 Compare April 16, 2025 08:26
@ycchuang99 ycchuang99 force-pushed the deprecate-drop-general-identity-attributes branch from 83ec475 to c0c9237 Compare April 16, 2025 08:32
@codecov
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.83%. Comparing base (39a2b48) to head (c0c9237).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1565      +/-   ##
============================================
- Coverage     70.90%   70.83%   -0.07%     
+ Complexity     2771     2756      -15     
============================================
  Files           409      407       -2     
  Lines          8365     8328      -37     
============================================
- Hits           5931     5899      -32     
+ Misses         2434     2429       -5     
Flag Coverage Δ
8.1 70.57% <100.00%> (-0.04%) ⬇️
8.2 70.79% <100.00%> (+0.06%) ⬆️
8.3 70.76% <100.00%> (-0.03%) ⬇️
8.4 70.74% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/SDK/Trace/SpanLimitsBuilder.php 62.50% <100.00%> (+1.27%) ⬆️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39a2b48...c0c9237. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ycchuang99 ycchuang99 marked this pull request as ready for review April 16, 2025 13:45
@brettmc brettmc merged commit e2f24eb into open-telemetry:main Apr 16, 2025
10 of 11 checks passed
@ycchuang99 ycchuang99 deleted the deprecate-drop-general-identity-attributes branch April 17, 2025 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SDK should NOT drop user.* attributes by default anymore

2 participants