Skip to content

Conversation

@smaddock
Copy link
Contributor

@smaddock smaddock commented May 19, 2025

I don't know if this is considered a breaking change or not, but it fixes an issue I raised.

Fixes: #1600

@smaddock smaddock requested a review from a team as a code owner May 19, 2025 20:41
@welcome
Copy link

welcome bot commented May 19, 2025

Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one.

@codecov
Copy link

codecov bot commented May 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.49%. Comparing base (691c0d4) to head (e22a523).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1603      +/-   ##
============================================
+ Coverage     69.33%   69.49%   +0.16%     
  Complexity     2805     2805              
============================================
  Files           414      414              
  Lines          8585     8585              
============================================
+ Hits           5952     5966      +14     
+ Misses         2633     2619      -14     
Flag Coverage Δ
8.1 69.11% <ø> (+0.05%) ⬆️
8.2 69.29% <ø> (+<0.01%) ⬆️
8.3 69.38% <ø> (+0.11%) ⬆️
8.4 69.24% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/Contrib/Otlp/OtlpHttpTransportFactory.php 80.00% <ø> (ø)
src/SDK/Common/Export/Http/PsrTransportFactory.php 78.57% <ø> (ø)

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 691c0d4...e22a523. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bobstrecansky bobstrecansky merged commit 23c3cda into open-telemetry:main May 21, 2025
11 checks passed
@smaddock smaddock deleted the issue-1600 branch May 21, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change return type on PsrTransportFactory->create() to interface

3 participants