add Logger.Enabled event name parameter #1632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extra parameter added in spec 1.45.0, which is optional and development stability
Nevay
approved these changes
Jun 12, 2025
Contributor
Author
|
I think the test failures are specific to xdebug 3.4.3, and a fix has just been released in https://xdebug.org/updates#x_3_4_4 |
weslenteche
approved these changes
Jun 19, 2025
ChrisLightfootWild
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extra parameter, "event name", added in spec 1.45.0 which is optional and development stability
see https://github.com/open-telemetry/opentelemetry-specification/blob/v1.45.0/specification/logs/api.md#enabled
I've left LogRecordProcessor.enabled as a todo, as we're not using it and it would require another interface to avoid BC break (plus, we're not using it and it's not marked stable)