Skip to content

Conversation

@Nevay
Copy link
Contributor

@Nevay Nevay commented Oct 13, 2025

Allows propagating additional data to nested component providers and env component loaders via Context::withExtension().
This PR makes ResourceInfo available to all SDK component providers besides resource detectors.

For example JaegerRemoteSampler needs to know the service name when calling the GetSamplingStrategy endpoint.

Additionally fixes service.name always being unknown_service:php when using declarative config.

@Nevay Nevay requested a review from a team as a code owner October 13, 2025 13:35
@codecov
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

❌ Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.39%. Comparing base (ddb222d) to head (9af3763).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../Config/SDK/ComponentProvider/OpenTelemetrySdk.php 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1729      +/-   ##
============================================
+ Coverage     68.37%   68.39%   +0.02%     
- Complexity     2971     2973       +2     
============================================
  Files           448      448              
  Lines          9020     9028       +8     
============================================
+ Hits           6167     6175       +8     
  Misses         2853     2853              
Flag Coverage Δ
8.1 68.11% <63.63%> (+0.05%) ⬆️
8.2 68.26% <63.63%> (+0.01%) ⬆️
8.3 68.30% <63.63%> (+0.09%) ⬆️
8.4 68.35% <63.63%> (+0.10%) ⬆️
8.5 68.22% <63.63%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/API/Configuration/Context.php 90.00% <100.00%> (+90.00%) ⬆️
.../Config/SDK/ComponentProvider/OpenTelemetrySdk.php 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddb222d...9af3763. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@brettmc brettmc merged commit b155847 into open-telemetry:main Oct 19, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants