Support symfony 8 #1839
Open
Support symfony 8 #1839
+39
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1839 +/- ##
============================================
+ Coverage 68.30% 68.46% +0.15%
Complexity 2976 2976
============================================
Files 449 449
Lines 8724 8723 -1
============================================
+ Hits 5959 5972 +13
+ Misses 2765 2751 -14
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
In Symfony 8, the NodeParentInterface was changed to an empty interface, removing method declarations that existed in Symfony 5-7. The fluent builder methods (end(), scalarNode(), etc.) still exist on concrete classes but are no longer part of the interface signature. Additionally, Symfony 8 removed template parameters from node definition classes, causing TooManyTemplateParams errors for our internal NodeDefinition classes that extend Symfony's base classes.
Author
|
hi @brettmc @bobstrecansky could you please have a look when you have time ? |
Contributor
|
I'll be happy to review once the CLA is signed. Thanks in advance @Orest-Divintari ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.