Skip to content

Add a Shutdown() method to *Provider SDK#1074

Merged
bogdandrutu merged 5 commits intoopen-telemetry:masterfrom
XSAM:shutdown-provider
Oct 14, 2020
Merged

Add a Shutdown() method to *Provider SDK#1074
bogdandrutu merged 5 commits intoopen-telemetry:masterfrom
XSAM:shutdown-provider

Conversation

@XSAM
Copy link
Copy Markdown
Member

@XSAM XSAM commented Oct 8, 2020

Resolve #1073

@XSAM XSAM requested review from a team October 8, 2020 10:44
@XSAM XSAM force-pushed the shutdown-provider branch from 5fc13bc to 7e39f65 Compare October 8, 2020 10:49
@XSAM XSAM force-pushed the shutdown-provider branch from 986daa8 to 91be904 Compare October 9, 2020 03:29
Copy link
Copy Markdown
Member

@Oberon00 Oberon00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! I'm definitely in favor of adding Shutdown

@arminru
Copy link
Copy Markdown
Member

arminru commented Oct 9, 2020

@XSAM Please add the respective entries in CHANGELOG.md and spec-compliance-matrix.md. Thanks!

@XSAM XSAM changed the title Add a Shutdown() method to *Provider Add a Shutdown() method to *Provider SDK Oct 13, 2020
Copy link
Copy Markdown
Member

@Oberon00 Oberon00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Oberon00 Oberon00 added area:sdk Related to the SDK priority:p1 Highest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:metrics Related to the specification/metrics directory spec:trace Related to the specification/trace directory labels Oct 13, 2020
@bogdandrutu bogdandrutu merged commit c115d08 into open-telemetry:master Oct 14, 2020
@XSAM XSAM deleted the shutdown-provider branch October 14, 2020 15:40
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
* Add a Shutdown() method to `*Provider`

* Add more precise description

* Update description of shutting down a provider

* Update CHANGELOG & spec-compliance-matrix

* Remove Shutdown function from API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:sdk Related to the SDK priority:p1 Highest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:metrics Related to the specification/metrics directory spec:trace Related to the specification/trace directory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a Shutdown() method to *Provider

6 participants