Skip to content

Parameters for private key and its chain added#2370

Merged
carlosalberto merged 7 commits intoopen-telemetry:mainfrom
jkamon:main
Mar 17, 2022
Merged

Parameters for private key and its chain added#2370
carlosalberto merged 7 commits intoopen-telemetry:mainfrom
jkamon:main

Conversation

@jkamon
Copy link
Copy Markdown
Contributor

@jkamon jkamon commented Feb 21, 2022

Adds possibility to configure client certificate for mTLSs.

@jkamon jkamon requested review from a team February 21, 2022 08:43
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Feb 21, 2022 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

anuraaga
anuraaga reviewed Feb 21, 2022
View reviewed changes
@jarias-lfx
Copy link
Copy Markdown

jarias-lfx commented Feb 22, 2022

/easycla

@jkamon
Copy link
Copy Markdown
Contributor Author

jkamon commented Feb 24, 2022

@anuraaga , @carlosalberto do I need approval to run jobs again?

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 4, 2022

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Mar 4, 2022
@jkamon
Copy link
Copy Markdown
Contributor Author

jkamon commented Mar 7, 2022

Bump.
@carlosalberto what needs to be done to move forward with this?

@github-actions github-actions bot removed the Stale label Mar 8, 2022
@jkamon
Copy link
Copy Markdown
Contributor Author

jkamon commented Mar 9, 2022

@anuraaga do you know who needs to be contacted in order to get this checked? And how to contact him/her? Slack channel question was not answered at all.

@anuraaga
Copy link
Copy Markdown
Contributor

anuraaga commented Mar 10, 2022

@tigrannajaryan @reyang Any help on this?

@carlosalberto
Copy link
Copy Markdown
Contributor

carlosalberto commented Mar 10, 2022

Hey, sorry for the delay.

Poking the spec approvers on this. If there's no traction, I will present this in the next Spec meeting (Tuesday), and if there's no more movement very shortly after, we can merge by then, as we the change is succint and logical (and we have enough approvals now).

Take a look @open-telemetry/specs-approvers

jack-berg
jack-berg reviewed Mar 15, 2022
View reviewed changes
jack-berg
jack-berg approved these changes Mar 16, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed a typo but otherwise 👍

jkamon and others added 2 commits March 16, 2022 19:13
@jkamon @jack-berg
Update specification/protocol/exporter.md
48ed445 
Co-authored-by: jack-berg <34418638+jack-berg@users.noreply.github.com>
@carlosalberto
Merge branch 'main' into main
8e17400
@carlosalberto carlosalberto merged commit 7680667 into open-telemetry:main Mar 17, 2022
@jack-berg jack-berg mentioned this pull request Mar 22, 2022
Closed
@ahayworth ahayworth mentioned this pull request May 11, 2022
Closed
@kaylareopelle kaylareopelle mentioned this pull request Jul 8, 2024
Merged
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
@jkamon
Parameters for private key and its chain added (open-telemetry#2370)
db3d70f 
* Parameters for private key and its chain added

* CLIENT_KEY_CHAIN renamed to CLIENT_CERTIFICATE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carlosalberto carlosalberto carlosalberto approved these changes

@reyang reyang reyang approved these changes

@jack-berg jack-berg jack-berg approved these changes

+1 more reviewer

@anuraaga anuraaga anuraaga approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@carlosalberto carlosalberto

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jkamon @jarias-lfx @anuraaga @carlosalberto @reyang @jack-berg