Skip to content

Fix inconsistent metric usage of http.target#2818

Merged
reyang merged 9 commits intoopen-telemetry:mainfrom
jack-berg:http-metric-inconsistency
Oct 3, 2022
Merged

Fix inconsistent metric usage of http.target#2818
reyang merged 9 commits intoopen-telemetry:mainfrom
jack-berg:http-metric-inconsistency

Conversation

@jack-berg
Copy link
Copy Markdown
Member

@jack-berg jack-berg commented Sep 21, 2022

Resolves #2335.

  • Removes http.url from http client metrics. There is no parameterized corollary to http.url and its unlikely that http client libraries would be able to provide a parameterized version.
  • Replace http.target with http.route in http server metrics.

These changes align the semantics of attributes in http traces and metrics.

@jack-berg jack-berg requested review from a team September 21, 2022 20:17
@reyang reyang added area:semantic-conventions Related to semantic conventions spec:metrics Related to the specification/metrics directory semconv:HTTP labels Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:semantic-conventions Related to semantic conventions semconv:HTTP spec:metrics Related to the specification/metrics directory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace http.url and http.target in http metric conventions

7 participants